-
Notifications
You must be signed in to change notification settings - Fork 2
Feature/#183 save user recent searches (last 5) #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
brauliodiez
merged 4 commits into
main
from
feature/#183-save-user-recent-searches-(last-5)
Mar 11, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
56624de
feat: save user recent search
manugallegob 6a2262d
Merge remote-tracking branch 'origin/main' into feature/#183-save-use…
manugallegob dfe882c
refactor(recent-searches): improve validation and fix hydration issues
manugallegob 184f926
Merge branch 'main' into feature/#183-save-user-recent-searches-(last-5)
brauliodiez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export * from './recent-searches'; |
3 changes: 3 additions & 0 deletions
3
front/src/pods/embalse-search/components/recent-searches/index.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| export * from "./recent-searches.component" | ||
| export * from "./useRecentSearches.hook" | ||
| export * from "./recentSearches.bussiness" |
23 changes: 23 additions & 0 deletions
23
front/src/pods/embalse-search/components/recent-searches/recent-searches.component.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import Link from "next/link"; | ||
| import { EmbalseSearchModel } from "../../embalse-search.vm"; | ||
|
|
||
| interface Props { | ||
| searches: EmbalseSearchModel[]; | ||
| } | ||
|
|
||
| export const RecentSearches: React.FC<Props> = (props) => { | ||
| const { searches } = props; | ||
|
|
||
| return ( | ||
| <> | ||
| <h3>Búsquedas recientes</h3> | ||
| <ul> | ||
| {searches.map((item) => ( | ||
| <li key={item.slug} className="mt-3"> | ||
| <Link className="link-accessible" href={`/embalse/${item.slug}`}>{item.name} </Link> | ||
| </li> | ||
| ))} | ||
| </ul> | ||
| </> | ||
| ); | ||
| }; |
41 changes: 41 additions & 0 deletions
41
front/src/pods/embalse-search/components/recent-searches/recentSearches.bussiness.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import { EmbalseSearchModel } from "../../embalse-search.vm"; | ||
|
|
||
| const MAX_SEARCHES = 5; | ||
|
|
||
| export const getStoredSearches = (): EmbalseSearchModel[] => { | ||
| try { | ||
| const storedSearches = localStorage.getItem("recent-searches"); | ||
| if (storedSearches) { | ||
| const parsedStoredSearches = JSON.parse(storedSearches); | ||
| const isValidData = | ||
| Array.isArray(parsedStoredSearches) && | ||
| parsedStoredSearches.every( | ||
| (item) => | ||
| item && | ||
| typeof item.slug === "string" && | ||
| typeof item.name === "string", | ||
| ); | ||
| return isValidData ? parsedStoredSearches : []; | ||
| } else { | ||
| return []; | ||
| } | ||
| } catch (error) { | ||
| console.log( | ||
| "Error al recuperar búsquedas recientes en el localstorage ", | ||
| error, | ||
| ); | ||
| return []; | ||
| } | ||
| }; | ||
|
|
||
| export const addNewSearchEntry = ( | ||
| newSearchEntry: EmbalseSearchModel, | ||
| recentSearches: EmbalseSearchModel[], | ||
| ) => { | ||
| const filteredRecentSearches = recentSearches.filter( | ||
| (search) => search.slug !== newSearchEntry.slug, | ||
| ); | ||
| return [newSearchEntry, ...filteredRecentSearches].slice(0, MAX_SEARCHES); | ||
| }; | ||
|
|
||
|
|
37 changes: 37 additions & 0 deletions
37
front/src/pods/embalse-search/components/recent-searches/useRecentSearches.hook.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| import { useState, useEffect } from "react"; | ||
| import { EmbalseSearchModel } from "../../embalse-search.vm"; | ||
| import { | ||
| addNewSearchEntry, | ||
| getStoredSearches, | ||
| } from "./recentSearches.bussiness"; | ||
|
|
||
| export const useRecentSearches = () => { | ||
| const [recentSearches, setRecentSearches] = useState<EmbalseSearchModel[]>( | ||
| [], | ||
| ); | ||
|
|
||
| useEffect(() => { | ||
| setRecentSearches(getStoredSearches()); | ||
| }, []); | ||
|
|
||
| const addNewEmbalseToLatestSearchCollection = ( | ||
| newSearch: EmbalseSearchModel, | ||
| ) => { | ||
| setRecentSearches((prevSearches) => { | ||
| const updatedRecentSearchColletion = addNewSearchEntry( | ||
| newSearch, | ||
| prevSearches, | ||
| ); | ||
| localStorage.setItem( | ||
| "recent-searches", | ||
| JSON.stringify(updatedRecentSearchColletion), | ||
| ); | ||
| return updatedRecentSearchColletion; | ||
| }); | ||
| }; | ||
|
|
||
| return { | ||
| recentSearches, | ||
| addNewEmbalseToLatestSearchCollection, | ||
| }; | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could simplify this, something like: