Open
Conversation
salcock
reviewed
Jun 20, 2021
| LPI_PROTO_KERBEROS, | ||
| LPI_CATEGORY_KEY_EXCHANGE, | ||
| "Kerberos", | ||
| 200, |
Contributor
There was a problem hiding this comment.
Since this rule is so weak, I think the priority should be set to 250 just so it is run after any other possible matches.
salcock
reviewed
Jun 20, 2021
|
|
||
| /* Quite a weak rule, first 4 bytes of kerberos is the record length which | ||
| * is spread over multiple packets */ | ||
|
|
Contributor
There was a problem hiding this comment.
Could we also add a check that if the value of data->payload[x] < 1400, then it must match data->payload_size[x]? Or can small records still be spread across multiple packets?
Just trying to think of ways where we can rule out certain payload patterns that might just happen to be on port 88 -- very unlikely, I know, but anything to make this rule seem a bit stronger...
salcock
requested changes
Jun 20, 2021
Contributor
salcock
left a comment
salcock
left a comment
There was a problem hiding this comment.
See inline comments on the kerberos module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds RPC module
Adds Kerberos module
Improves LLDP module when using multi byte lengths