perf: Zip MDS rows in the inner apply_mds loop - #60
Open
vadorovsky wants to merge 1 commit into
Open
vadorovsky wants to merge 1 commit into
vadorovsky wants to merge 1 commit into
Conversation
vadorovsky
force-pushed
the
vad/apply-mds
branch
from
September 21, 2026 06:57
ec8fc48 to
c07b5b7
Compare
Indexing the MDS matrix as `mds[i][j]` bounds-checks and chases the row
pointer on every inner iteration. Zipping the state iterator with the
row slice removes both and improves performance.
Before:
```
poseidon_bn254_x5_1 time: [23.550 µs 23.586 µs 23.629 µs]
poseidon_bn254_x5_2 time: [33.843 µs 33.914 µs 33.990 µs]
poseidon_bn254_x5_3 time: [45.972 µs 46.023 µs 46.080 µs]
poseidon_bn254_x5_4 time: [64.794 µs 64.868 µs 64.950 µs]
poseidon_bn254_x5_5 time: [83.945 µs 84.056 µs 84.183 µs]
poseidon_bn254_x5_6 time: [111.81 µs 111.93 µs 112.08 µs]
poseidon_bn254_x5_7 time: [143.60 µs 143.76 µs 143.94 µs]
poseidon_bn254_x5_8 time: [174.56 µs 175.58 µs 176.93 µs]
poseidon_bn254_x5_9 time: [204.46 µs 204.78 µs 205.15 µs]
poseidon_bn254_x5_10 time: [271.73 µs 272.08 µs 272.48 µs]
poseidon_bn254_x5_11 time: [296.99 µs 297.33 µs 297.74 µs]
poseidon_bn254_x5_12 time: [376.47 µs 376.79 µs 377.26 µs]
```
After:
```
poseidon_bn254_x5_1 time: [23.066 µs 23.174 µs 23.325 µs]
change: [-2.2081% -1.8589% -1.3974%] (p = 0.00 < 0.05)
Performance has improved.
Found 10 outliers among 100 measurements (10.00%)
6 (6.00%) high mild
4 (4.00%) high severe
poseidon_bn254_x5_2 time: [32.838 µs 32.869 µs 32.904 µs]
change: [-3.0838% -2.9449% -2.8031%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
3 (3.00%) high mild
4 (4.00%) high severe
poseidon_bn254_x5_3 time: [44.638 µs 44.666 µs 44.696 µs]
change: [-3.1142% -2.9264% -2.7627%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild
poseidon_bn254_x5_4 time: [63.564 µs 63.667 µs 63.789 µs]
change: [-1.7487% -1.5015% -1.1982%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
1 (1.00%) high mild
4 (4.00%) high severe
poseidon_bn254_x5_5 time: [82.885 µs 82.967 µs 83.072 µs]
change: [-1.5774% -1.3842% -1.2051%] (p = 0.00 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
2 (2.00%) high mild
4 (4.00%) high severe
poseidon_bn254_x5_6 time: [110.84 µs 110.96 µs 111.10 µs]
change: [-1.0675% -0.9438% -0.8197%] (p = 0.00 < 0.05)
Change within noise threshold.
Found 4 outliers among 100 measurements (4.00%)
2 (2.00%) high mild
2 (2.00%) high severe
poseidon_bn254_x5_7 time: [142.01 µs 142.19 µs 142.39 µs]
change: [-1.2473% -1.0711% -0.9154%] (p = 0.00 < 0.05)
Change within noise threshold.
Found 5 outliers among 100 measurements (5.00%)
4 (4.00%) high mild
1 (1.00%) high severe
poseidon_bn254_x5_8 time: [173.71 µs 173.91 µs 174.11 µs]
change: [-0.9042% -0.5522% -0.2606%] (p = 0.00 < 0.05)
Change within noise threshold.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild
poseidon_bn254_x5_9 time: [204.29 µs 205.15 µs 206.12 µs]
change: [-0.0241% +0.5845% +1.2478%] (p = 0.06 > 0.05)
No change in performance detected.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild
poseidon_bn254_x5_10 time: [267.99 µs 268.63 µs 269.34 µs]
change: [-1.3121% -0.9879% -0.7280%] (p = 0.00 < 0.05)
Change within noise threshold.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild
poseidon_bn254_x5_11 time: [292.10 µs 292.62 µs 293.23 µs]
change: [-1.6042% -1.4175% -1.2132%] (p = 0.00 < 0.05)
Performance has improved.
Found 17 outliers among 100 measurements (17.00%)
15 (15.00%) high mild
2 (2.00%) high severe
poseidon_bn254_x5_12 time: [369.39 µs 370.32 µs 371.35 µs]
change: [-2.6819% -2.0366% -1.6086%] (p = 0.00 < 0.05)
Performance has improved.
```
vadorovsky
force-pushed
the
vad/apply-mds
branch
from
September 21, 2026 06:58
c07b5b7 to
2408b39
Compare
vadorovsky
marked this pull request as ready for review
September 21, 2026 06:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indexing the MDS matrix as
mds[i][j]bounds-checks and chases the row pointer on every inner iteration. Zipping the state iterator with the row slice removes both and improves performance.Before:
After: