glibc/wasmtime - libc fatal debug workaround #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rennergade
changed the title
Contributor
|
this needs to pass the linter, we may also want to discuss if this is what we want to do here but also this PR is less essential than the others in blocking progress. |
Yaxuan-w
reviewed
Aug 25, 2025
Member
Yaxuan-w
left a comment
Yaxuan-w
left a comment
There was a problem hiding this comment.
Should be great to have documentations that explain the mechanism and usage. Thanks
| __libc_message ("Fatal glibc error: %s:%s (%s): assertion failed: %s\n", | ||
| file, linestr, function, assertion); | ||
| #endif | ||
| } |
| * c-basic-offset: 2 | ||
| * End: | ||
| */ | ||
| */ |
rennergade
reviewed
Nov 17, 2025
| )?; | ||
|
|
||
| // a temporary solution to have libc_assert_fail correctly working | ||
| linker.func_wrap( |
Contributor
There was a problem hiding this comment.
these are both basically write() syscalls, instead of adding these host functions can't we just use write? Once the addr translation PR is in that should be easy right? @qianxichen233 @drapl0n
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is splited from PR #164
This PR focuses on spliting out the temporary debug solution for glibc fatal. Previously, when glibc crushes, there is no debug information getting printed out, which is pretty inconvenient. The reason behind it is that the
libc_assert_failandmalloc_printerrfunction in glibc is not working correctly. This PR provides an temporary solution to have the error message directly passed to wasmtime to print the error