Hide PSP player count in recent activity - #223
Conversation
|
@Toastbrot236 This remains one clean commit on current main and implements member-authored good-first issue #50 using the existing GameVersion.LBPPSP value. I re-ran npm test (3/3), the app TypeScript check, the production Angular build, and diff check; all pass, with only the existing 1.07 kB bundle-budget warning. The fork Build is stopped at action_required before any jobs start. Could you approve the workflow and review when convenient? |
|
I honestly don't know what to do with this PR. While I haven't tested whether it actually does hide PSP player counts yet, the logic looks decent enough. But, since refresh-web doesn't have anything related to unit testing yet (no testing workflow, no actual unit tests etc), I'd rather take care of that in a separate PR. Also, I don't understand what you're trying to say with your last message, can you please reword it in your own words? |
2e646a8 to
ff5aa1f
Compare
|
Sure — I removed the test script and test files. The PR now only checks whether the score came from PSP before showing the player count. I also ran the TypeScript check and production build locally; both pass. The GitHub build has not run because workflows from forks need a maintainer to approve them. |
Summary
Closes #50
Validation
npx tsc --noEmit -p tsconfig.app.jsonnpm run build(passes with the existing initial-bundle budget warning)