Add PR number to output when triggered by push#13
Open
teleological wants to merge 1 commit intoLogerfo:masterfrom
Open
Add PR number to output when triggered by push#13teleological wants to merge 1 commit intoLogerfo:masterfrom
teleological wants to merge 1 commit intoLogerfo:masterfrom
Conversation
DeepCode Report (#d6a2c7)DeepCode analyzed this pull request. |
Logerfo
requested changes
Nov 8, 2019
Comment on lines
+77
to
+78
| When triggered by a push event, the pull request number which is created or found to | ||
| already exist is stored in the `pull-request` output variable. |
Owner
There was a problem hiding this comment.
Please don't break markdown lines like that. If you're bothered by the horizontal scrollbar, consider activating the word wrap in your text editor (ALT+Z, if you're using VSCode 🙂).
Contributor
Author
There was a problem hiding this comment.
My editor did this without me noticing. Will correct.
| core.info(`Label ${label} added to #${pull_number}.`); | ||
| core.debug(JSON.stringify(labelsResponse.data)); | ||
| } | ||
| core.setOutput("pull-request", pull_number.toString()); |
Owner
There was a problem hiding this comment.
I think we're supposed to add this to the action.yml file. Check out the documentation.
Owner
|
Thanks for the PR. Did you find yourself any useful workflow using the new output? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It might be desirable to output the pull number when handling other triggers, but I wasn't sure what would be useful in the case of
check_run, when multiple PRs might be merged, so I kept my change narrow.View rendered README.md