Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a dynamic API facade, Map2LoopAPI, that discovers and instantiates classes from the map2loop package, and it provides regression tests to validate this functionality.
- Implements Map2LoopAPI with dynamic class discovery and instantiation.
- Exposes Map2LoopAPI at the package root for external use.
- Adds regression tests to cover API listing, class retrieval, and instance creation.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_api.py | Adds tests for listing available classes, retrieving classes, and creating instances. |
| map2loop/api.py | Implements the dynamic class discovery and API facade functionality. |
| map2loop/init.py | Exposes Map2LoopAPI in the package root. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Map2LoopAPIfacade that dynamically discovers classesMap2LoopAPIin package rootTesting
pytest tests/test_api.py -q(fails: ModuleNotFoundError: No module named 'osgeo')pip install gdal==3.6.2(fails: Could not find gdal-config)https://chatgpt.com/codex/tasks/task_e_685b86747438832fa992ef294ac164d6