-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Modify live activity #2397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Modify live activity #2397
Conversation
* add section headings; * modify strings
ExplanationWhen testing some of the changes, the difficulty of handling large fonts made some of my initial changes impractical. Instead, I added one more section to the Live Active screen display and added section headings to each. This enables expanded text strings that work for large and bold font. Suggested ChangesThere are several suggestions in lokalise (from Felix) for preferred wording for the row labels.
Discussion
Additional Changes
TestWhen I made the proposed change from "Mode" to "Display on Lock Screen" the use of large font made it very difficult to modify the selection. Even restoring to "Mode" was too long to see both the label and the picker. Therefore, I restored the title to "Mode" and the shortened the picker selection choices to "Plot and Row" vs "Row" only. Section headings were added to every existing section as well as for the new section. To DoThings to fix -
|
|
I like these changes. @ps2 has a strong opinion about the use of COB & IOB: #2191 (comment). A proposal for the #2392 is send via DM to Marion, Inspiration: https://stackoverflow.com/questions/75697214/swift-charts-draw-a-line-chart-where-line-color-is-determined-by-the-y-value I do think Active Insulin & Active Carbohydrates should be consistent in the Configure Display view (if that would be the new label for it):
|
|
Hi Marion, In the current implementation changing the "large"/"small" selection to a more descriptive wording should be easy. On the other hand: in the current implemention with the selection-wheel it should be quite easy to add additional configurations of the live-activity, e.g. displaying only the graph without any numbers in the bottom row. Cheers, Felix |
|
@polyfeux I modified the UI substantially. I think adding screenshots of the current configuration will make discussions easier. These graphics were prepared with commit f66d332
Composite of Live Activity UI screens with nominal font size
Composite of Live Activity Mode selection with enlarged font size
|
CommentsRefer to the screenshot composites in #2397 (comment).
|
Update the glucose color plotUsing code revision from @bastiaanv, commit 101cde2, fixes the bug reported in Issue #2392 TestConfigure a test phone which has flat glucose pattern
Build with the proposed change from @bastiaanv. The graphic shows the lock screen plot prior to the update on the left with the modified code on the right.
Confirm when color is disabled, the glucose plot returns to Loop blue with bottom row using black font when phone is light mode or white font when phone is in dark mode. |
Update descriptionsWith this commit, 6575f96, the following changes were implemented.
TestThis was tested with nominal, larger and extremely large text sizes. The interface continues to be usable. GraphicsThe composite below uses this more recent commit.
|





Purpose
Address Issues #2391, #2396 reported with the version of Live Activity release with Loop version 3.10.0.
If possible, also address issue #2392.
Method
Information:
nameis the string displayed in the widgetdescriptionis the string displayed when choosing what is shown in the bottom row of the widgetAction:
namedescriptionto make it easier for the user to know what that selection doesDid a search for how to prevent truncation and settled on adding this
Test
For both an iOS 18 and an iOS 26 test phone, set font size to use accessibility sizes and select the largest size.
devbranch and the strings were still no longer truncated