fix: don't overwrite persisted displaycal settings on every boot#772
Open
pvaibhav wants to merge 1 commit into
Open
fix: don't overwrite persisted displaycal settings on every boot#772pvaibhav wants to merge 1 commit into
pvaibhav wants to merge 1 commit into
Conversation
InitSettings() applied device displaycal defaults unconditionally, even for shm clients, so user-customized white point correction never survived a reboot on tg5040. Seed device defaults only in the host branch and only when the persisted file lacked displaycal fields (fresh defaults or pre-v11 migration), mirroring the h700 fix.
Collaborator
|
I wonder if this is related to launching custom paks that run InitSettings on boot in helpers - I know I do that in my pak binaries... |
Author
For sure could be. From what I understand all the shared memory clients call this function and thus reset the displaycal settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InitSettings() applied device displaycal defaults unconditionally, even for shm clients, so user-customized white point correction never survived a reboot on tg5040. Seed device defaults only in the host branch and only when the persisted file lacked displaycal fields (fresh defaults or pre-v11 migration), mirroring the h700 fix.
Closes #773