fix: unify color parsing#774
Merged
Merged
Conversation
…here it was missed
carroarmato0
added a commit
to carroarmato0/NextUI
that referenced
this pull request
Jul 11, 2026
Integrates the new upstream commits since c24b36d, adapted to the cpp20-migration branch's C++/DeviceDescriptor architecture. New upstream work brought in: - feat: Trimui Brick Pro support (LoveRetro#766) + fix: trigger LEDs not addressable (MAX_LIGHTS 4->5) - fix: unify color parsing (LoveRetro#774) -- also fixes a hex_str[9] overflow and missed alpha in colour presets - feat: configurable button hint styles (LoveRetro#763) - Update README license notice; Dependabot GitHub Actions bumps Brick Pro reconciliation (adopt upstream semantics): Our branch had its own Brick-family Brick Pro (commit 0a64688). Per decision, upstream's richer, distinct-device model is adopted and re-expressed through our DeviceDescriptor architecture: - is_brickpro is now separate from is_brick (no longer a Brick-family member); isBrickModel() helper removed. - TG5040_BRICK_PRO descriptor carries the new joy_l4=11, joy_r4=12, joy_menu_alt=15; L4/R4 trigger buttons wired through descriptor-driven JOY_L4/R4 macros and BTN_ID_L4/R4. - Five-zone LED layout (F1, F2, top bar, joysticks, rear triggers) with ledsettings_brickpro.txt and LED_PATH4; own brightness curve and displaycal preset via libmsettings. - platform.h keeps our descriptor macros (not upstream's is_brick|| is_brickpro ternaries); tg5050 descriptor gets explicit JOY_NA for the new fields. Feature ports kept our C++20 idioms: colorpickermenu/menu keep SurfacePtr RAII and GFX_getFonts() accessors while taking upstream's semantic fixes; button-hint input_rects added alongside our encapsulated font accessor. Duplicate BrickPro enumerator in settings.cpp resolved to upstream's. Upstream's re-enabled PLAT_pollInput debug LOG_info lines kept commented. Validated: full clean build on tg5040 (device target, incl. Brick Pro paths). Brick Pro remains hardware-unverified on both sides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.