Skip to content

Conversation

@akobrin1
Copy link
Contributor

@akobrin1 akobrin1 commented Dec 5, 2025

  • Expanded devnet config to gate Network Maker with enable/port settings and updated samples accordingly (devnet/config/config.{go,json}, devnet/config/validators.json).
  • Docker compose generation now builds a custom bridged network with static IPs and exposes Network Maker gRPC/HTTP/UI ports plus related defaults/env wiring (devnet/generators/config.go, devnet/generators/docker-compose.go).
  • Devnet image installs Node 25 and nginx, copies the new control scripts, and opens NM/UI ports 50051/8080/8088 (devnet/dockerfile).
  • Runtime scripts enhanced: configure copies NM UI assets; start launches NM setup and serves the UI via nginx; new stop/restart helpers manage lumera/supernode/network-maker/nginx; NM setup respects per-validator ports (devnet/scripts/configure.sh, devnet/scripts/start.sh, devnet/scripts/stop.sh, devnet/scripts/restart.sh, devnet/scripts/network-maker-setup.sh).
  • Devnet Makefile gains a default binaries upgrade target and now syncs stop/restart scripts into running containers (Makefile.devnet).

@roomote
Copy link

roomote bot commented Dec 5, 2025

Rooviewer Clock   See task on Roo Cloud

Review complete.

  • Inject VITE_API_BASE into static UI files
  • Unconditionally inject VITE_API_BASE for validators with Network Maker enabled
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

case "${START_MODE}" in
auto|*)
launch_network_maker_setup

P1 Badge Honor START_MODE-specific code paths

The case statement treats auto|* as the first branch, so the * pattern matches every START_MODE value and the later bootstrap, run, and wait cases never execute. As a result the script always follows the auto flow (launching setup, starting lumerad, tailing logs) even when callers request the documented bootstrap or wait modes. Any compose invocation relying on those modes will ignore the chosen START_MODE and behave like auto instead.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@akobrin1 akobrin1 requested a review from a-ok123 December 7, 2025 18:22
@mateeullahmalik mateeullahmalik merged commit 40d0cba into master Dec 16, 2025
8 checks passed
@mateeullahmalik mateeullahmalik deleted the devnet-nm-ui branch December 16, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants