Feature/action list by creator

[j-rafique]

PR Description

Summary

• Add ListActionsByCreator query (gRPC/REST/autocli) to fetch actions by creator with tests and generated proto artifacts.
• Fix pagination and supernode lookup edge cases across action queries; improve autocli wiring

[roomote]

Rooviewer   See task on Roo Cloud

I've reviewed the latest changes (commit 53c0880), which added a test case for invalid creator addresses. The critical performance issues flagged in previous reviews (full table scans in ListActionsByBlockHeight, ListActionsBySuperNode, GetSuperNodeByAccount, and ListExpiredActions) remain unaddressed. These queries are currently O(N) and pose a stability risk.

• Optimize ListExpiredActions to use state index instead of full scan
• Add index maintenance for ListActionsByBlockHeight in SetAction
• Add index maintenance for ListActionsBySuperNode in SetAction
• Add index maintenance for GetSuperNodeByAccount in SetSuperNode
• Avoid redundant memory allocation in ListActionsByCreator
• Implement index-based lookup for ListActionsByBlockHeight
• Implement index-based lookup for GetSuperNodeByAccount
• Implement index-based lookup for ListActionsBySuperNode
• Fix DoS vector in ListActionsByBlockHeight (remove fallback scan)
• Fix DoS vector in ListActionsBySuperNode (remove fallback scan)
• Fix DoS vector in GetSuperNodeByAccount (remove fallback scan)
• Add migration for ListActionsByBlockHeight index backfill
• Add migration for ListActionsBySuperNode index backfill
• Add migration for GetSuperNodeByAccount index backfill
• Avoid redundant memory allocation in ListExpiredActions

Previous reviews

• 144fd0f: Review #1
• 8dc78a1: Review #2
• b5a8896: Review #3
• 9d68129: Review #4
• afba78d: Review #5
• e716e62: Review #6

_{Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.}

[Copilot]

Pull request overview

This PR adds a new ListActionsByCreator query endpoint to fetch actions by creator address, along with improvements to pagination logic and supernode lookup across several existing query implementations.

Key Changes

• Added new ListActionsByCreator gRPC/REST query with pagination support and corresponding test coverage
• Refactored pagination logic in action queries to use FilteredPaginate consistently and properly handle filtering
• Added GetSuperNodeByAccount method to improve supernode lookups by account address
• Enhanced autocli configuration with comprehensive query command descriptors
• Added Total field to query responses for better pagination information

Reviewed changes

Copilot reviewed 16 out of 17 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
proto/lumera/action/v1/query.proto	Added ListActionsByCreator RPC definition with request/response messages
x/action/v1/types/query.pb.go	Generated protobuf code for new query types and updated descriptor indices
x/action/v1/types/query.pb.gw.go	Generated gRPC-gateway handlers for new REST endpoint
x/action/v1/types/action.pb.go	Reformatted imports (cosmetic change)
x/action/v1/keeper/query_list_actions_by_creator.go	Implemented new query handler using creator index for efficient lookups
x/action/v1/keeper/query_list_actions_by_creator_test.go	Added comprehensive test coverage for the new query including edge cases
x/action/v1/keeper/query_list_actions.go	Refactored to use state index when filtering by state for better performance
x/action/v1/keeper/query_list_actions_by_sn.go	Improved pagination logic and added Total field to response
x/action/v1/keeper/query_list_actions_by_block_height.go	Improved pagination logic and added Total field to response
x/action/v1/keeper/query_list_expired_actions.go	Improved pagination logic and added Total field to response
x/action/v1/keeper/action.go	Minor refactoring of index management code (inline error checks)
x/action/v1/module/autocli.go	Added comprehensive autocli command descriptors for all query endpoints
x/supernode/v1/types/expected_keepers.go	Added GetSuperNodeByAccount to interface definition and reordered imports
x/supernode/v1/mocks/expected_keepers_mock.go	Generated mock implementation for new interface method
x/supernode/v1/keeper/supernode.go	Implemented GetSuperNodeByAccount, improved pagination filtering, added default case handling in SetSuperNodeActive
x/supernode/v1/keeper/query_get_super_node_by_super_node_address.go	Refactored to use new GetSuperNodeByAccount method instead of full scan
x/supernode/v1/keeper/msg_server_stop_supernode.go	Fixed indentation (cosmetic change)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[roomote]

Rooviewer   Follow along on Roo Cloud

I've reviewed the latest changes (commit 53c0880). While the test coverage has improved, the critical performance issues (full table scans) in several queries remain unaddressed. The fallback logic was removed, but without implementing the necessary secondary indexes and migrations, these queries are inefficient and pose a DoS risk.

• Optimize ListExpiredActions to use state index instead of full scan
• Add index maintenance for ListActionsByBlockHeight in SetAction and migration
• Add index maintenance for ListActionsBySuperNode in SetAction and migration
• Add index maintenance for GetSuperNodeByAccount in SetSuperNode and migration
• Avoid redundant memory allocation in ListActionsByCreator
• Implement index-based lookup for ListActionsByBlockHeight
• Implement index-based lookup for GetSuperNodeByAccount
• Implement index-based lookup for ListActionsBySuperNode
• Fix DoS vector in ListActionsByBlockHeight (remove fallback scan)
• Fix DoS vector in ListActionsBySuperNode (remove fallback scan)
• Fix DoS vector in GetSuperNodeByAccount (remove fallback scan)
• Add migration for ListActionsByBlockHeight index backfill
• Add migration for ListActionsBySuperNode index backfill
• Add migration for GetSuperNodeByAccount index backfill
• Avoid redundant memory allocation in ListExpiredActions

Previous reviews

• 144fd0f: Review #1
• 8dc78a1: Review #2
• b5a8896: Review #3
• 9d68129: Review #4
• afba78d: Review #5
• e716e62: Review #6
• 53c0880: Review #7

_{Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.}