Skip to content

Conversation

@j-rafique
Copy link
Contributor

No description provided.

@j-rafique j-rafique marked this pull request as ready for review December 12, 2025 21:23
@roomote
Copy link

roomote bot commented Dec 12, 2025

Rooviewer Clock   Follow along on Roo Cloud

I've reviewed the changes and found a few issues that should be addressed before merging.

  • Race condition in sqlite.Start vs Stop
  • Ignoring errors in os.Remove in supernode_start.go
  • Start logic brittleness in monitor_service.go (network calls on startup)
  • hm.reportInterval safety check missing
  • Health checks targeting Public IP instead of localhost
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@j-rafique j-rafique changed the title WIP(Super Node Metrics) Super Node Metrics Dec 13, 2025
@mateeullahmalik mateeullahmalik changed the title Super Node Metrics Supernode Selfreport Dec 15, 2025
@j-rafique j-rafique merged commit d442a2f into master Dec 16, 2025
2 of 7 checks passed
mateeullahmalik added a commit that referenced this pull request Dec 23, 2025
mateeullahmalik added a commit that referenced this pull request Dec 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants