Code Review Exercise: Sofia Bezertzi - #120

Open

smpezert wants to merge 27 commits into

MCR-Digital:masterfrom

smpezert:master

Commits on Jan 8, 2024

rename int HowManyPlayers to NumberOfPlayers
smpezert
committed
1ddacf0
rename from aGame to round
smpezert
committed
c331167
rename index to questionNumber
smpezert
committed
80f31cd
remove duplicate code
smpezert
committed
33d888d
rename method from movePlace to moveAndAskQuestion
smpezert
committed
d98576c
remove duplicate in askquestion method adding askAndRemoveQuestion method
smpezert
committed
d498bd1
extract new bool method for winner
smpezert
committed
9ba0833
extract number 6 to consts for total coins for winning and maximum number of players
smpezert
committed
dcf51f9
extract to const the minimum number of palyers
smpezert
committed
5eb2ac8
extract total number of players to const
smpezert
committed
28a6abc
extract const for total places in board and bool for roll if it is odd
smpezert
committed
265037c
refactor 11 to total places of board -1
smpezert
committed
6835eee

Commits on Jan 9, 2024

add modifier to consts (private and readonly)
smpezert
committed
5a5bf3e
add readonly to the list players
smpezert
committed
b9872af
rename methods related to answers
smpezert
committed
a034133
move all private methods to the bottom
smpezert
committed
496a205
extract the method ask question from movelocation because of single responsibility principal
smpezert
committed
2653c38
extract contitional logic from roll method
smpezert
committed
0b93b2a
extract nested contitional logic from the method IsAnswerCorrect
smpezert
committed
3bf6042
move private method lower to the private methods
smpezert
committed
4eb05f4
add categories class
smpezert
committed
8b46606
add deck class to the solution and extract properties
smpezert
committed
633e37c
add new player class and use it in the game class
smpezert
committed
154ae43
remove places, purses and inPenaltyBox variables from add method
smpezert
committed
606c335
update inPenaltyBox using the new setter from player class
smpezert
committed
b68d822
update places using the pnew setter from Player class
smpezert
committed
b0328f9
update purse using the purse setter from the player class
smpezert
committed
c07a57b