Refresh README, docs landing page, and scaling plots#1152
Refresh README, docs landing page, and scaling plots#1152sbryngelson merged 25 commits intoMFlowCode:masterfrom
Conversation
- Add tagline and hero blockquote (Gordon Bell, 200T grid points, exascale) - Promote shock-droplet image to hero position - Add "Why MFC?" section with 6 key differentiators - Streamline "Try MFC" with direct Codespace link and first-simulation command - Remove redundant Getting Started section (Codespaces detail, macOS from-source) - Deduplicate citation block and star CTA (each appeared twice) - Move star history chart to bottom - Fix 3 broken doc links: md_examples, md_running, md_getting-started Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…caling plot Add 2025 Gordon Bell Prize Finalist tagline to hero section, OpenGraph and Twitter Card meta tags for link sharing, GitHub stars badge, updated SEO meta description, and replace Frontier+Summit scaling plots with a single three-machine weak scaling figure (El Capitan, Frontier, Alps). Fix LLNL typo and add El Capitan to compute resources footer. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add alt attributes to all badge <img> tags for accessibility (MD045). Normalize GPU scaling sub-list indentation from mixed tabs/spaces to consistent 4-space indent. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
logo2.png does not exist in docs/res/, causing broken social previews. Use banner.png which is a known-good asset. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Added a link to GitHub assets in the README.
Remove the static shockdrop.png in favor of the embedded shedding water droplet simulation video, which auto-plays and loops on GitHub. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Updated link to the largest known public CFD simulation.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace per-system Frontier SVG with new combined GPU weak scaling PNG covering El Capitan (MI300A), Frontier (MI250X), and Alps (GH200). Mark Summit-era sections as historical. Fix typos. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use <div> instead of <p> for proper centering of video element. Add controls attribute as fallback when autoplay is blocked. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Update "Is this really exascale?" with combined El Capitan/Frontier/Alps weak scaling plot. Remove Discussions badge since Discussions is disabled. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Generate inverted-grayscale dark variant of weak scaling plot while preserving colored data points. Use <picture> element for automatic light/dark mode switching, matching the star history chart pattern. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The Doxygen docs site uses a dark theme, so the dark variant of the weak scaling plot matches better. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fix outdated 'init' subcommand references to 'new' in the Toolchain table and tab completion note. Remove duplicate shock-droplet run command and visualization text already covered in Try MFC section. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThis PR updates documentation styling, configuration, and content across multiple files. Changes include fixing image badge URLs in README, updating Doxygen configuration text, modifying documentation CSS and templates, replacing Vimeo video links with YouTube sources, and standardizing documentation reference titles. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This comment was marked as resolved.
This comment was marked as resolved.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This comment was marked as resolved.
This comment was marked as resolved.
|
CodeAnt AI finished reviewing your PR. |
- Remove stray %09 (encoded tab) from shields.io badge color params - Use light scaling plot in docs (works in both themes) - Fix "LLNL LC" to "LLNL" in docs footer Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ⓘ You are approaching your monthly quota for Qodo. Upgrade your plan PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
There was a problem hiding this comment.
High-level Suggestion
The PR removes the footer from auto-generated documentation pages by emptying docs/footer.html. This change eliminates crucial breadcrumb navigation, harming site usability. [High-level, importance: 9]
Solution Walkthrough:
Before:
<!-- docs/footer.html -->
<!-- ... -->
<div id="nav-path" class="navpath"><!-- id is needed for treeview function! -->
<ul>
$navpath
<li class="footer">$generatedby <a href="..."><img ... alt="doxygen"/></a> $doxygenversion </li>
</ul>
</div>
<!-- ... -->
</body>
</html>After:
<!-- docs/footer.html -->
<!-- HTML footer for doxygen 1.9.1-->
<!-- start footer part -->
<!--BEGIN GENERATE_TREEVIEW-->
<!--END GENERATE_TREEVIEW-->
<!--BEGIN !GENERATE_TREEVIEW-->
<!--END !GENERATE_TREEVIEW-->
</body>
</html>| <!-- HTML footer for doxygen 1.9.1--> | ||
| <!-- start footer part --> | ||
| <!--BEGIN GENERATE_TREEVIEW--> | ||
| <div id="nav-path" class="navpath"><!-- id is needed for treeview function! --> | ||
| <ul> | ||
| $navpath | ||
| <li class="footer">$generatedby <a href="https://www.doxygen.org/index.html"><img class="footer" src="$relpath^doxygen.svg" width="104" height="31" alt="doxygen"/></a> $doxygenversion </li> | ||
| </ul> | ||
| </div> | ||
| <!--END GENERATE_TREEVIEW--> | ||
| <!--BEGIN !GENERATE_TREEVIEW--> | ||
| <hr class="footer"/><address class="footer"><small> | ||
| $generatedby <a href="https://www.doxygen.org/index.html"><img class="footer" src="$relpath^doxygen.svg" width="104" height="31" alt="doxygen"/></a> $doxygenversion | ||
| </small></address> | ||
| <!--END !GENERATE_TREEVIEW--> | ||
| </body> | ||
| </html> |
There was a problem hiding this comment.
Suggestion: Restore the closing </body> and </html> tags in docs/footer.html. Removing them will produce invalid HTML for the generated documentation, which can cause browser rendering issues. [possible issue, importance: 8]
| <!-- HTML footer for doxygen 1.9.1--> | |
| <!-- start footer part --> | |
| <!--BEGIN GENERATE_TREEVIEW--> | |
| <div id="nav-path" class="navpath"><!-- id is needed for treeview function! --> | |
| <ul> | |
| $navpath | |
| <li class="footer">$generatedby <a href="https://www.doxygen.org/index.html"><img class="footer" src="$relpath^doxygen.svg" width="104" height="31" alt="doxygen"/></a> $doxygenversion </li> | |
| </ul> | |
| </div> | |
| <!--END GENERATE_TREEVIEW--> | |
| <!--BEGIN !GENERATE_TREEVIEW--> | |
| <hr class="footer"/><address class="footer"><small> | |
| $generatedby <a href="https://www.doxygen.org/index.html"><img class="footer" src="$relpath^doxygen.svg" width="104" height="31" alt="doxygen"/></a> $doxygenversion | |
| </small></address> | |
| <!--END !GENERATE_TREEVIEW--> | |
| </body> | |
| </html> | |
| <!-- This file is intentionally left almost empty to remove the default Doxygen footer. --> | |
| <!-- It must contain the closing body and html tags for valid HTML output. --> | |
| </body> | |
| </html> |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1152 +/- ##
=======================================
Coverage 44.07% 44.07%
=======================================
Files 70 70
Lines 20431 20431
Branches 1974 1974
=======================================
Hits 9004 9004
Misses 10291 10291
Partials 1136 1136 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
User description
Summary
init→new, remove dead Discussions badge, remove duplicate instructions<picture>element) in both README and docs performance pageTest plan
./mfc.sh precheckpasses (all 5 checks)🤖 Generated with Claude Code
CodeAnt-AI Description
Refresh README and docs landing to highlight exascale results, add hero video, unify scaling plots, and simplify quickstart
What Changed
./mfc.sh new(replacesinit) and point to the consolidated examples and getting-started pageImpact
✅ Clearer project intro for new visitors✅ Shorter quickstart to run first simulation (one-click Codespace + single command)✅ Better social previews and shareable links (OG/Twitter, YouTube, DOI badges)💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Summary by CodeRabbit
Bug Fixes
New Features
Documentation
Style