Merged
Conversation
ian-ross
requested changes
Mar 30, 2026
Member
ian-ross
left a comment
ian-ross
left a comment
There was a problem hiding this comment.
I think this is looking pretty good. I have a few comments it would be good to address, but otherwise it's very nice. This is quite a bit better than the last couple of PRs you've had. Good work!
ian-ross
approved these changes
Mar 30, 2026
Member
ian-ross
left a comment
ian-ross
left a comment
There was a problem hiding this comment.
This looks good now. The CI failure is because of a Sphinx version thing. I've fixed it in the Python version PR I have open, so I'll merge that one, rebase this and then merge when the CI is passing. I'll deal with it later on today.
ian-ross
force-pushed
the
nvPM_functions
branch
from
9e23f6a to
b2e613a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses the nvPM Mission Emissions Estimation Methodology Paper (Ahrens et al., 2023) and SCOPE11 (2019) to implement nvPM emission calculations into AEIC
Fixes #110
TASKS FOR THIS PR: