Conversation
setup unit test
for now I don't use the one from MJ2, we will need to figure out how to
allow both implemenations to pass.
Add inject and extract of SMPTE ST 2094-50 metadata from json file
Trying to inject new mebx track
Create test for each injection type
Fixes Clang warnings and errors.
Add includes to SMPTE_ST2094_50.cpp
…. Add json testing with video
ST2094-50: fix quantization constant and refine logic for common flag
Fix wrong condition for has_common_curve_params_flag at encoding Reformat print of binary
replace gainCurveControlPointTheta by gainCurveControlPointM and add conversion from slope to angle
Fix flag checking (got overwrote by last merge) Fix extract looging format
Missing closing mediaEdits
Quantization can result in sum of quantized value not equal to 50000 (1.0). Scaling by the sum of all custom coefficient. Also fixed wrong common flag set at encode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds comprehensive ITU-T T.35 metadata support to libisomediafile plus a new command-line tool for injecting/extracting SMPTE ST 2094-50 dynamic HDR metadata.
What's New
Library (
libisomediafile):it35(T.35 sample entry),mebx(boxed metadata),colr(color info)ISONewMebxSampleDescription(),ISOAddMebxMetadataToSampleEntry()Tool (
t35_tool):Usage: