DL Master Skill Tree Attack Skills Completion by ze-dom · Pull Request #750 · MUnique/OpenMU

ze-dom · 2026-04-09T14:34:17Z

To-do:

Comment changes with source references
Update plugin

Developments:

Added magic effects to DL master skill tree offensive skills
Added missing Electric Spark penalty for party members
Added maximum duration for Increase Critical Chance buff
Added Fire Scream's explosion damage effect

Bugfixes:

DL master skill tree ancestor skill replacements
Earthshake AoE range & pushback

ze-dom · 2026-04-09T14:36:51Z

+                partyMember.Attributes[Stats.CurrentMana] *= 0.95f;
+            }
+        }
+


zTeamS6.3, emu

ze-dom · 2026-04-09T14:39:58Z

zTeamS6.3: 0, 1, 2
emu: 0, 1, 2

ze-dom · 2026-04-09T14:46:42Z

        this.CreateSkill(SkillNumber.Force, "Force", CharacterClasses.AllLords, DamageType.Physical, 10, 4, manaConsumption: 10);
        this.CreateSkill(SkillNumber.FireBurst, "Fire Burst", CharacterClasses.AllLords, DamageType.Physical, 100, 6, manaConsumption: 25, energyRequirement: 79, skillTarget: SkillTarget.ExplicitWithImplicitInRange, implicitTargetRange: 1);
        this.CreateSkill(SkillNumber.Earthshake, "Earthshake", CharacterClasses.AllLords, DamageType.Physical, 150, 10, 50, elementalModifier: ElementalType.Lightning, skillType: SkillType.AreaSkillAutomaticHits);
+        this.AddAreaSkillSettings(SkillNumber.Earthshake, false, 0, 0, 0, useTargetAreaFilter: true, targetAreaDiameter: 10, minimumHitsPerAttack: 9, maximumHitsPerAttack: 15);


The previous range of 10 (and pushback) was insane! Everything would go flying off the screen! 😅
zTeamS6.3, emu

ze-dom · 2026-04-09T14:47:59Z

        this.CreateSkill(SkillNumber.InfinityArrow, "Infinity Arrow", CharacterClasses.MuseElfAndHighElf, distance: 6, abilityConsumption: 10, manaConsumption: 50, levelRequirement: 220, skillType: SkillType.Buff, targetRestriction: SkillTargetRestriction.Self);
        this.CreateSkill(SkillNumber.FireScream, "Fire Scream", CharacterClasses.AllLords, DamageType.Physical, 130, 6, 10, 45, energyRequirement: 70, leadershipRequirement: 150, skillType: SkillType.AreaSkillAutomaticHits);
-        this.AddAreaSkillSettings(SkillNumber.FireScream, true, 2f, 3f, 6f); // TODO: Add fireScream's explosion (Explosion79) damage effect
+        this.AddAreaSkillSettings(SkillNumber.FireScream, true, 2f, 3f, 6f);


This might be too short. It happened that I could attack and not hit with the S6E3 client.

ze-dom · 2026-04-09T14:58:24Z

-        this.AddMasterSkillDefinition(SkillNumber.EarthshakeMastery, SkillNumber.EarthshakeStreng, SkillNumber.Undefined, 2, 4, SkillNumber.Earthshake, 20, Formula120);
-        this.AddMasterSkillDefinition(SkillNumber.CritDmgIncPowUp3, SkillNumber.CritDmgIncPowUp2, SkillNumber.Undefined, 2, 5, SkillNumber.IncreaseCriticalDamage, 20, Formula181);
+        this.AddMasterSkillDefinition(SkillNumber.FireBurstMastery, SkillNumber.FireBurstStreng, SkillNumber.Undefined, 2, 4, SkillNumber.FireBurstStreng, 20, $"{Formula120} / 100", Formula120, Stats.StunChance, AggregateType.AddRaw);
+        this.AddMasterSkillDefinition(SkillNumber.CritDmgIncPowUp2, SkillNumber.CriticalDmgIncPowUp, SkillNumber.Undefined, 2, 4, SkillNumber.CriticalDmgIncPowUp, 20, Formula803, true);


zTeamS6.3, emu

ze-dom · 2026-04-09T15:00:21Z

+        this.AddMasterSkillDefinition(SkillNumber.FireBurstMastery, SkillNumber.FireBurstStreng, SkillNumber.Undefined, 2, 4, SkillNumber.FireBurstStreng, 20, $"{Formula120} / 100", Formula120, Stats.StunChance, AggregateType.AddRaw);
+        this.AddMasterSkillDefinition(SkillNumber.CritDmgIncPowUp2, SkillNumber.CriticalDmgIncPowUp, SkillNumber.Undefined, 2, 4, SkillNumber.CriticalDmgIncPowUp, 20, Formula803, true);
+        this.AddMasterSkillDefinition(SkillNumber.EarthshakeMastery, SkillNumber.EarthshakeStreng, SkillNumber.Undefined, 2, 4, SkillNumber.EarthshakeStreng, 20, $"{Formula120} / 100", Formula120, Stats.StunChance, AggregateType.AddRaw);
+        this.AddMasterSkillDefinition(SkillNumber.CritDmgIncPowUp3, SkillNumber.CritDmgIncPowUp2, SkillNumber.Undefined, 2, 5, SkillNumber.CritDmgIncPowUp2, 20, $"{Formula181} / 100", Formula181,  Stats.CriticalDamageChance, AggregateType.AddRaw);


zTeamS6.3, emu

ze-dom · 2026-04-09T15:03:26Z

-        this.AddMasterSkillDefinition(SkillNumber.CritDmgIncPowUp3, SkillNumber.CritDmgIncPowUp2, SkillNumber.Undefined, 2, 5, SkillNumber.IncreaseCriticalDamage, 20, Formula181);
+        this.AddMasterSkillDefinition(SkillNumber.FireBurstMastery, SkillNumber.FireBurstStreng, SkillNumber.Undefined, 2, 4, SkillNumber.FireBurstStreng, 20, $"{Formula120} / 100", Formula120, Stats.StunChance, AggregateType.AddRaw);
+        this.AddMasterSkillDefinition(SkillNumber.CritDmgIncPowUp2, SkillNumber.CriticalDmgIncPowUp, SkillNumber.Undefined, 2, 4, SkillNumber.CriticalDmgIncPowUp, 20, Formula803, true);
+        this.AddMasterSkillDefinition(SkillNumber.EarthshakeMastery, SkillNumber.EarthshakeStreng, SkillNumber.Undefined, 2, 4, SkillNumber.EarthshakeStreng, 20, $"{Formula120} / 100", Formula120, Stats.StunChance, AggregateType.AddRaw);


zTeamS6.3, emu

ze-dom · 2026-04-09T15:05:17Z

-        this.AddMasterSkillDefinition(SkillNumber.CritDmgIncPowUp2, SkillNumber.CriticalDmgIncPowUp, SkillNumber.Undefined, 2, 4, SkillNumber.IncreaseCriticalDamage, 20, Formula803);
-        this.AddMasterSkillDefinition(SkillNumber.EarthshakeMastery, SkillNumber.EarthshakeStreng, SkillNumber.Undefined, 2, 4, SkillNumber.Earthshake, 20, Formula120);
-        this.AddMasterSkillDefinition(SkillNumber.CritDmgIncPowUp3, SkillNumber.CritDmgIncPowUp2, SkillNumber.Undefined, 2, 5, SkillNumber.IncreaseCriticalDamage, 20, Formula181);
+        this.AddMasterSkillDefinition(SkillNumber.FireBurstMastery, SkillNumber.FireBurstStreng, SkillNumber.Undefined, 2, 4, SkillNumber.FireBurstStreng, 20, $"{Formula120} / 100", Formula120, Stats.StunChance, AggregateType.AddRaw);


zTeamS6.3, emu

ze-dom · 2026-04-09T15:07:45Z

        this.AddMasterSkillDefinition(SkillNumber.ForceWaveStreng, SkillNumber.Force, SkillNumber.Undefined, 2, 2, SkillNumber.ForceWave, 20, Formula632);
        this.AddPassiveMasterSkillDefinition(SkillNumber.DarkHorseStreng1, Stats.BonusDefenseWithHorse, AggregateType.AddRaw, Formula1204, 2, 2);
-        this.AddMasterSkillDefinition(SkillNumber.CriticalDmgIncPowUp, SkillNumber.IncreaseCriticalDamage, SkillNumber.Undefined, 2, 3, SkillNumber.IncreaseCriticalDamage, 20, Formula632);
+        this.AddMasterSkillDefinition(SkillNumber.CriticalDmgIncPowUp, SkillNumber.IncreaseCriticalDamage, SkillNumber.Undefined, 2, 3, SkillNumber.IncreaseCriticalDamage, 20, Formula632, Formula632, Stats.CriticalDamageBonus, AggregateType.AddRaw);


zTeamS6.3, emu

ze-dom · 2026-04-09T15:10:13Z

        magicEffect.SendDuration = false;
        magicEffect.StopByDeath = true;
+        magicEffect.Duration = this.Context.CreateNew<PowerUpDefinitionValue>();
+        magicEffect.Duration.ConstantValue.Value = 2; // 2 seconds


DK also has a stun effect of 2s in his MST (to do)

ze-dom · 2026-04-09T15:14:21Z

+    /// The critical damage increase mastery effect.
+    /// </summary>
+    CriticalDamageIncreaseMastery = 148,
+


Mastery uses a new magic effect number.
Previously (bugged) would display both:

ze-dom · 2026-04-09T15:15:32Z

        magicEffect.StopByDeath = true;
        magicEffect.Duration = this.Context.CreateNew<PowerUpDefinitionValue>();
        magicEffect.Duration.ConstantValue.Value = 60f;
+        magicEffect.Duration.MaximumValue = 180f;


ze-dom · 2026-04-09T15:20:22Z


        var currentDistance = startingPoint.EuclideanDistanceTo(currentTarget);
-        while (currentDistance < skillEntry.Skill.Range)
+        for (int i = 0; i < 3; i++)


zTeamS6.3, emu

ze-dom · 2026-04-09T15:28:49Z

        this.CreateSkill(SkillNumber.GiganticStorm, "Gigantic Storm", CharacterClasses.AllMGs, DamageType.Wizardry, 110, 6, 10, 120, 220, 118, elementalModifier: ElementalType.Wind, skillType: SkillType.AreaSkillAutomaticHits);
        this.CreateSkill(SkillNumber.ChaoticDiseier, "Chaotic Diseier", CharacterClasses.AllLords, DamageType.Physical, 190, 6, 15, 50, 100, 16, skillType: SkillType.AreaSkillAutomaticHits);
-        this.AddAreaSkillSettings(SkillNumber.ChaoticDiseier, true, 1.5f, 1.5f, 6f);
+        this.AddAreaSkillSettings(SkillNumber.ChaoticDiseier, true, 1.5f, 1.5f, 6f, minimumHitsPerAttack: 7);


zTeamS6.3 (7), emu (8)

ze-dom · 2026-04-14T20:54:47Z

        magicEffect.Number = (byte)MagicEffectNumber.CriticalDamageIncrease;
        magicEffect.Name = "Critical Damage Increase Skill Effect";
        magicEffect.InformObservers = true;
+        magicEffect.SubType = 17;


zTeamS6.3; emu: 1, 2

gemini-code-assist · 2026-04-14T20:58:56Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request finalizes the Dark Lord master skill tree by implementing missing skills, effects, and necessary data initializations. It introduces new mechanics for existing skills to improve combat balance and fixes identified bugs related to skill range and master skill inheritance.

Highlights

Dark Lord Master Skill Tree Completion: Completed the implementation of the Dark Lord master skill tree, including new magic effects and skill definitions.
Skill Enhancements: Added explosion damage to Fire Scream, implemented Electric Spark penalties for party members, and added a maximum duration for the Increase Critical Chance buff.
Bug Fixes: Resolved issues with ancestor skill replacements in the master skill tree and corrected Earthshake AoE range and pushback mechanics.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request completes the Dark Lord master tree skills and effects, including the implementation of the Fire Scream skill plugin and updates to Electric Spike and Earthshake skills. It also introduces several initialization updates for stun effects and critical damage increase mastery, alongside a fix for master skill duration calculations. Review feedback identifies potential runtime exceptions: one involving the risky use of First() on a collection that could be empty, and another regarding unsafe null-forgiving access to player attributes during party-wide status updates.

gemini-code-assist · 2026-04-14T21:05:46Z

+            var stunChancePowerUp = powerUps.First(p => p.Target == Stats.StunChance);
+            if (!Rand.NextRandomBool(Convert.ToDouble(stunChancePowerUp.Boost.Value)))
+            {
+                return;
+            }


Using First() here is risky as it will throw an InvalidOperationException if Stats.StunChance is not present in the powerUps collection. Since this depends on external skill configuration, using FirstOrDefault() with a null check is safer to prevent potential server crashes due to misconfigured data.

var stunChancePowerUp = powerUps.FirstOrDefault(p => p.Target == Stats.StunChance); if (stunChancePowerUp is null || !Rand.NextRandomBool(Convert.ToDouble(stunChancePowerUp.Boost.Value))) { return; }

gemini-code-assist · 2026-04-14T21:05:46Z

+                partyMember.Attributes![Stats.CurrentHealth] *= 0.8f;
+                partyMember.Attributes[Stats.CurrentMana] *= 0.95f;


Accessing partyMember.Attributes! with the null-forgiving operator is potentially unsafe. If a party member is in the process of disconnecting or has an uninitialized state, this could throw a NullReferenceException. It is safer to verify that Attributes is not null before performing the multiplication.

if (partyMember.Attributes is { } memberAttributes) { memberAttributes[Stats.CurrentHealth] *= 0.8f; memberAttributes[Stats.CurrentMana] *= 0.95f; }

First commit

dedccb6

ze-dom commented Apr 9, 2026

View reviewed changes

Change min hits per attack for chatic diseier

5804748

ze-dom commented Apr 9, 2026

View reviewed changes

ze-dom added 6 commits April 10, 2026 16:33

Fixed some bugs

0d12433

Added update plugin

1b57baf

Added contingencies to replace one magic effect for its "successor"

bfbb7eb

Moved condition check

eef9f8b

Forgot saving

c121c67

Added update version

6e19145

ze-dom commented Apr 14, 2026

View reviewed changes

ze-dom marked this pull request as ready for review April 14, 2026 20:58

gemini-code-assist bot reviewed Apr 14, 2026

View reviewed changes

ze-dom added 2 commits April 15, 2026 11:17

Implemented code bot suggestions

9052c34

Merge branch 'master' into DL_master_tree_finishup

4bcab35

		partyMember.Attributes![Stats.CurrentHealth] *= 0.8f;
		partyMember.Attributes[Stats.CurrentMana] *= 0.95f;

Conversation

ze-dom commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ze-dom Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ze-dom Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot commented Apr 14, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

ze-dom commented Apr 9, 2026 •

edited

Loading

ze-dom Apr 9, 2026 •

edited

Loading

ze-dom Apr 9, 2026 •

edited

Loading