Skip to content

Rename OfflineLevelingPlayer to OfflinePlayer#752

Open
eduardosmaniotto wants to merge 3 commits intoMUnique:masterfrom
eduardosmaniotto:feature/offlevel-rename
Open

Rename OfflineLevelingPlayer to OfflinePlayer#752
eduardosmaniotto wants to merge 3 commits intoMUnique:masterfrom
eduardosmaniotto:feature/offlevel-rename

Conversation

@eduardosmaniotto
Copy link
Copy Markdown
Contributor

Renamed OfflineLeveling folder and namespace to Offline across the codebase, including directory structure, all related classes, test files, and resource files.
This change was made in preparation for a possible /offstore command which would make using Leveling on class names misleading.
Also:

  • Fixed a bug with party XP distribution in low rate configuration. And add write lock.
  • Refactored BuffHandler for readability.

@eduardosmaniotto eduardosmaniotto marked this pull request as ready for review April 11, 2026 21:02
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on a significant refactoring effort to rename the 'OfflineLeveling' feature to 'Offline' throughout the application, enhancing clarity and future-proofing the codebase. Alongside this major renaming, it addresses a critical bug in party experience distribution and improves the internal structure of the buff handling logic for better code quality.

Highlights

  • Codebase Renaming: The 'OfflineLeveling' folder, namespace, and related classes (e.g., OfflineLevelingPlayer, OfflineLevelingManager, OfflineLevelingIntelligence) have been comprehensively renamed to 'Offline' (e.g., OfflinePlayer, OfflinePlayerManager, OfflinePlayerMuHelper) across the entire codebase, including directory structure, class files, test files, and resource files. This change anticipates a potential '/offstore' command, making the 'Leveling' suffix misleading.
  • Party XP Distribution Fix: A bug affecting party experience (XP) distribution in low rate configurations has been fixed. Additionally, a write lock has been added to the Party class to ensure thread safety during member modifications.
  • BuffHandler Refactoring: The BuffHandler class has been refactored for improved readability and maintainability. This includes renaming internal variables and introducing new private helper methods to encapsulate specific buff application logic.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request rebrands the "Offline Leveling" feature to "Offline Player" through extensive renaming of classes, namespaces, and UI elements across the project. It also refactors the Party class to use an array for member storage with a dedicated write lock and updates experience distribution to use floating-point precision. Feedback identifies a potential race condition in the party dissolution logic and suggests optimizing BuffHandler by removing redundant list allocations.

Comment thread src/GameLogic/Party.cs Outdated
Comment thread src/GameLogic/Offline/BuffHandler.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant