Conversation
The app device setup wizard queries /product/info for model details. Bumper had no handler, so the wizard stalled. Reuses responses from existing configNetAll and productIotMap data instead of hardcoding per-model entries. Also fixes stale entries in the static config files.
|
hey, nice one! a few notes from my side: static jsons - pls don't edit manually
if something is missing or needs to be changed in that data, that can't be fixed in the script or also heads up: the downloader script itself is getting a rework in #268 - The merging part with The old vs new appthere is no planning right now for supporting both old and new app versions. ruff
for mid in mids:
if robot := lookup.get(mid):
result.append(_robot_to_product_info(robot))
return resultjust make it a list comprehension: return [
_robot_to_product_info(robot)
for mid in mids
if (robot := lookup.get(mid))
]Please also include a python test case for the new api ( |
Description
The app device setup wizard queries
/product/infofor model details. Bumper had no handler, so the wizard stalled. Uses the responses from existing configNetAll and productIotMap data instead of hardcoding per-model entries.Also fixes stale entries in the static config files.
I'm unsure about the changes in
get_product_entry_group(). The new app refuses to work properly without that change. Also unsure how best to address it and test it with an older version I guess.Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Test Configuration:
Checklist: