-
Notifications
You must be signed in to change notification settings - Fork 265
Adding CCi to M2 #4040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Adding CCi to M2 #4040
Conversation
Matrix internals have changed
Add factory patch
RRb and CCb will be added later and will use GC-allocated memory.
|
I don't know why the test is failing (did we break something or is something bigger broken?) Help would be appreciated. I found the change that was causing this. But, I'm not sure the best way to do this. |
|
I briefly checked over the most recent changes, and I'm OK with them. I didn't see any drastic changes there (indenting and tests, only, I think). I also did a check with my local copy, and I didn't see any issues. I'm ok with merging whenever you're happy (and the review has passed). |
Add helper methods for the "midpoint" of a ring (which is the ring where the midpoints of polynomials lie).
antonleykin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm taken away a bit by
i8 : # methods regularizedBeta
o8 = 125
for a method with basic usage:
regularizedBeta(x, a, b)
* Inputs:
* x, a "real number",
* a, a "real number",
* b, a "real number",
* Outputs:
* a "real number",
Indeed,
|
Yeah, we could probably replace most of those with something like |
Previously, we were just adding/subtracting 1 first, and thus losing precision for small inputs.
This way, we don't have to worry about storing them as methods for all four different InexactNumber types.
|
This is a bit more manageable! i1 : methods regularizedBeta
o1 = {0 => (regularizedBeta, Number, InexactNumber, InexactNumber) }
{1 => (regularizedBeta, InexactNumber, Number, InexactNumber) }
{2 => (regularizedBeta, InexactNumber, InexactNumber, Number) }
{3 => (regularizedBeta, Number, Number, InexactNumber) }
{4 => (regularizedBeta, Number, InexactNumber, Number) }
{5 => (regularizedBeta, InexactNumber, Number, Number) }
{6 => (regularizedBeta, Number, Number, Number) }
{7 => (regularizedBeta, InexactNumber, InexactNumber, InexactNumber)}
o1 : NumberedVerticalList |
Not quite correct since they're only defined for RR, but this way the Number methods will get defined in typicalvalues.m2.
This is work started at the M2 conference in Madison. This is the pull request to add CCi support to M2. This includes implementations in the M2 language, the D-language, and aring support for polynomials and matrices in the back-end.