add a test for the mod helper#478
Open
c-tonneslan wants to merge 1 commit into
Open
Conversation
mod has been documented since the math docs were written but never covered by tests, so a regression would have slipped through. Drop in a TestMod that exercises a couple of representative inputs to match the surrounding TestDiv/TestMul style and pin down the operand order (the piped value is the right-hand operand). Closes Masterminds#458. Signed-off-by: Charlie Tonneslan <cst0520@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #458.
`mod` has been documented in `docs/math.md` since the math docs were written but never covered by tests, so a regression would have slipped through. `TestMod` exercises a couple of representative inputs to match the surrounding `TestDiv` / `TestMul` style and pins down the operand order (the piped value is the right-hand operand).