Skip to content

fix: do not wait for the data to mount health chart components - #374

Merged
MatteoGabriele merged 1 commit into
MatteoGabriele:mainfrom
graphieros:health-transitions
Aug 23, 2026
Merged

fix: do not wait for the data to mount health chart components#374
MatteoGabriele merged 1 commit into
MatteoGabriele:mainfrom
graphieros:health-transitions

Conversation

@graphieros

@graphieros graphieros commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

This just removes the await on the health chart components' data composable, which prevented the components from mounting until resolve. Applied on both health chart components.
Transitioning from daily to hourly should now be (more) snappy.

Summary by CodeRabbit

  • Performance Improvements
    • Improved chart loading responsiveness by allowing event data to initialize without blocking component setup.
    • Preserved reactive access to global and hourly event data.

@netlify

netlify Bot commented Aug 23, 2026

Copy link
Copy Markdown

Deploy Preview for agentscan ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8cf9948
🔍 Latest deploy log https://app.netlify.com/projects/agentscan/deploys/6a8aa83dc8d8110008267197
😎 Deploy Preview https://deploy-preview-374--agentscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 18f04bc6-3a63-4ed6-9f2a-b90df47c85e0

📥 Commits

Reviewing files that changed from the base of the PR and between 0b71124 and 8cf9948.

📒 Files selected for processing (2)
  • app/components/Chart/GlobalEventsEvolution.vue
  • app/components/Chart/HourlyEventsEvolution.vue

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The chart components now invoke useEcosystemHealth() and useEcosystemHealthHourlyWindow without await. This changes composable initialization from awaited to synchronous execution in both components. Reactive access to the composables’ data remains in place.

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 8cf99

This localized change removes blocking waits so health chart components can mount promptly; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: health chart components mount without waiting for data.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MatteoGabriele

Copy link
Copy Markdown
Owner

@MatteoGabriele
MatteoGabriele merged commit 382cd0b into MatteoGabriele:main Aug 23, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants