Add support for passing vectors of paths into MediaInfoList#1360
Open
hjmallon wants to merge 1 commit into
Open
Add support for passing vectors of paths into MediaInfoList#1360hjmallon wants to merge 1 commit into
hjmallon wants to merge 1 commit into
Conversation
hjmallon
force-pushed
the
feature/listsoffiles
branch
2 times, most recently
from
d19f384 to
d2cdd0d
Compare
hjmallon
force-pushed
the
feature/listsoffiles
branch
from
d2cdd0d to
f1fcd65
Compare
Contributor
|
Looks inefficient, creating a vector of one element when opening with a string. What about calling the existing string open in a loop for the vector one instead. Existing apps would be looping the string call when opening multiple files so this change will cause creation of many vectors with single element. The vector call cannot be exposed in the C API so not all apps can migrate to vector call too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an
Opencall for a vector of file paths.