Add profile image upload with local/S3 storage - #1041
Merged
nafiuishaaq merged 5 commits intoAug 2, 2026
Conversation
|
@No-bodyq Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
No-bodyq
force-pushed
the
feat/issue-993-avatar-upload
branch
from
July 26, 2026 20:47
e2d1f66 to
09f711e
Compare
No-bodyq
force-pushed
the
feat/issue-993-avatar-upload
branch
from
July 26, 2026 21:00
09f711e to
518a948
Compare
- auth.controller.ts had two full AuthController class bodies concatenated (a botched prior merge), which broke parsing for the whole file and cascaded into unrelated eslint type-resolution errors repo-wide - add missing @nestjs/swagger dependency (used throughout but never added to package.json) - fix relative import paths in auth.service.ts (an extra '../' pointed outside src/auth, breaking NodeNext module resolution) - add .js extensions to relative imports per the project's nodenext moduleResolution, removing further unresolved-type cascades - remove JwtAuthGuard's unresolvable third constructor parameter (a bare function type Nest can never inject), small unused-import/no-await cleanups, and a wrong TypeORM option name (connectTimeout -> connectTimeoutMS) - apply repo-wide prettier formatting (was never run on ~50 files) Lint: 95 errors -> 0. Build: failing -> passing. Prettier: 51 files -> 0.
No-bodyq
force-pushed
the
feat/issue-993-avatar-upload
branch
from
July 26, 2026 21:32
f252bb6 to
50212a7
Compare
…ation These specs were written against a device-aware, RefreshTokenService + UsersService backed refresh-token design that was never wired into AuthService/AuthController — the real implementation still uses the simpler in-memory nonce/token-map flow. Rewrite both specs to exercise what's actually there instead of leaving them permanently red.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #993
Note: this branch is stacked on #1040 (issue #976) for the shared Redis module wiring, so its diff will include those commits until that PR merges.
POST /user/avataraccepts a multipartfileupload, validates type (JPEG/PNG/WebP only), size (5MB max), and dimensions (200x200–2000x2000), rejecting anything outside those bounds with 400StorageProviderabstraction with local filesystem (dev) and S3 (STORAGE_DRIVER=s3, configured viaAWS_ACCESS_KEY/AWS_SECRET_ACCESS_KEY/AWS_REGION/AWS_S3_BUCKET) implementationsavatarUrlandavatarThumbnailUrlare saved on the user entity; the previous avatar's variants are deleted from storage when a new one is uploaded