Add admin panel enhancements according to #3283#618
Open
xkello wants to merge 5 commits into
Open
Conversation
Coverage Report for CI Build 26363486897Coverage remained the same at 93.215%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
MarcelGeo
requested changes
May 18, 2026
| * Call setFetchFn() immediately after setup to register the table-specific | ||
| * fetch action; all event handlers will invoke it automatically. | ||
| */ | ||
| export function useDataTableSearch(opts: DataTableSearchOptions = {}) { |
Collaborator
There was a problem hiding this comment.
It's not better to add here also watcher for route query params?
Contributor
Author
There was a problem hiding this comment.
I think it would cause an infinite loop: doFetch -> updateQuery -> router.replace -> route.query changes -> watcher -> doFetch... A guard flag could break it but it's unnecessary - the component remounts on back navigation so created() already handles state restore. A watcher would only add value in my opinion if the URL could change externally while the component is mounted which isn't the case here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add functionality according to https://github.com/MerginMaps/server-private/issues/3283.