-
Notifications
You must be signed in to change notification settings - Fork 41
feat(echo-start): auto register template referral system #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(echo-start): auto register template referral system #641
Conversation
|
@Cyber-Mitch is attempting to deploy a commit to the Merit Systems Team on Vercel. A member of the Team first needs to authorize it. |
|
@rsproule I'm done now |
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
|
suggestion applied |
rsproule
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this .echo/template.json file is a cool strategy. But we do not currently have a mechanism to hit the echo control plane authenticated from inside echo-start.
Have you explored other designs / strategies here ? Like perhaps doing this registration directly in the echo control console instead of in echo start?
If we go forward with this .echo/template.json strategy, we need to think further around how this referrer actually registers.
…ber-Mitch/echo into feat/template-referral-system
|
@rsproule please review |
|
Hello @rsproule you haven't reviewed yet |
|
Did you make any changes? I don't see answers to my questions in comments and this approach still does not actually do anything (doesn't register the referrer in echo) |
I'll make the changes now |
…ber-Mitch/echo into feat/template-referral-system
|
@rsproule Thanks for the feedback! I've updated the approach in this PR to address the issue of actually registering the referrer without needing authentication in echo-start. Instead of extracting a referral code and writing it to .env.local (which, as you noted, doesn't integrate with Echo's control plane), I've shifted to a link-based strategy:
|
|
@rsproule Kindly review |
|
@rsproule you haven't reviewed yet |
Description
package.json and upsert a framework-appropriate referral env var alongside the app ID.
Testing
This closes #611