-
Notifications
You must be signed in to change notification settings - Fork 41
feat: added vercel blob as intermediate layer #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@sachigoyal is attempting to deploy a commit to the Merit Systems Team on Vercel. A member of the Team first needs to authorize it. |
|
@sragss can you take a look |
|
@rsproule hey you can take a look again. everything seems to work. let me know if you want more changes |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rsproule
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few little things. also have you been able to test this locally? a demo video / screen recording would be super helpful for a change like this
| // For example: verify user session, check quotas, etc. | ||
|
|
||
| return { | ||
| allowedContentTypes: ['image/jpeg', 'image/png', 'image/gif', 'image/webp'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HEIC/HEIF ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the problem with these formats are that we can't render on the input box properly as browsers (mostly) don't support this format. we have to come up with hacks to convert to some other format (like png/jpg) and then render
do you think its worth installing few libraries and writing code to support this? or do you have any other plan?
let me know
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some models do support HEIC. But fair enough, we can consider this out of scope but its actually pretty trivial to do this conversion for browser: https://github.com/alexcorvi/heic2any
import heic2any from "heic2any";
const jpegBlob = await heic2any({ blob, toType: "image/jpeg" });
const url = URL.createObjectURL(jpegBlob);
document.querySelector("img").src = url;There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i actually gave it a try. it couldn't convert my iphone's heic format pictures
it throws error 'ERR_LIBHEIF format not supported'. thats why skipped it
tackles #561
current flow
Screen.Recording.2025-11-13.at.12.29.47.AM.mov