-
Notifications
You must be signed in to change notification settings - Fork 41
add Gemini image generation tool pricing #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@Trynax is attempting to deploy a commit to the Merit Systems Team on Vercel. A member of the Team first needs to authorize it. |
|
|
||
| switch (tool.type) { | ||
| case 'image_generation': { | ||
| const model = (tool as any).model; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty sure this does not exist here.
| const toolPricing = SupportedOpenAIResponseToolPricing; | ||
|
|
||
| switch (tool.type) { | ||
| case 'image_generation': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think that gemini returns the same types for tools image_generation tool is an open ai specific concept. we need to split out the Tool processing for each provider (just openai + gemini for now)
|
Have you been able to verify this? What has been your testing strategy? |
Yoo @rsproule just added a test that i ran locally. strategy is: |
fixes #661
Changes:
tool.modelfield incalculateToolCost()to detect Gemini modelsGeminiImageGenerationPricingtype and pricing constant to SDK