[BUG] test_langflow_components.py imports missing praisonai_task — wrapper unit collection aborts when Langflow installed

[Dhivya-Bharathy]

[BUG] test_langflow_components.py imports missing praisonai_task module — wrapper unit collection aborts when Langflow is installed

Metadata

Field	Value
Repository	https://github.com/MervinPraison/PraisonAI
Commit tested	5c7d76d72 (main, 2026-09-29)
Labels	bug, tests, langflow, ci
Severity	High — pytest src/praisonai/tests/unit exits 2; ~6k tests not collected
Component	src/praisonai/tests/unit/test_langflow_components.py
Missing module	praisonai.flow.components.PraisonAI.praisonai_task

---

Executive summary

When Langflow is installed (optional extra in pyproject.toml), pytest collection loads test_langflow_components.py. The file passes pytest.importorskip("langflow") then immediately imports:

from praisonai.flow.components.PraisonAI.praisonai_task import PraisonAITaskComponent

On current main, praisonai_task.py does not exist. Only these ship under praisonai/flow/components/PraisonAI/:

• praisonai_agent.py
• praisonai_agents.py

Collection fails with ModuleNotFoundError, pytest interrupts the entire wrapper unit tree (exit code 2), so most of src/praisonai/tests/unit never runs on developer machines that have Langflow (common when using Langflow/LFX tooling).

This is repo/test drift, not an environment misconfiguration.

---

Expected vs actual

Expected	Actual
Langflow optional tests skip or pass when extras installed	Collection ERROR if Langflow present
Shipped components match test imports	Test imports non-existent praisonai_task
pytest src/praisonai/tests/unit completes	Interrupted after 1 collection error

---

Terminal evidence (2026-09-29, Windows, Python 3.13, no OpenAI key)

$ pytest src/praisonai/tests/unit -q --tb=line
collected 6042 items / 1 error / 7 skipped

ERROR collecting src/praisonai/tests/unit/test_langflow_components.py
ImportError while importing test module '.../test_langflow_components.py'.
src/praisonai/tests/unit/test_langflow_components.py:4: in <module>
    from praisonai.flow.components.PraisonAI.praisonai_task import PraisonAITaskComponent
E   ModuleNotFoundError: No module named 'praisonai.flow.components.PraisonAI.praisonai_task'

!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
============= 7 skipped, 1 warning, 1 error in 393.79s (0:06:33) =============
exit code: 2

---

Root cause

1. Missing implementation: praisonai_task.py (and PraisonAITaskComponent) not present on main.
2. Test still references it at module import time (lines 4, 26–43, 53–58).
3. importorskip("langflow") is insufficient — it only skips when Langflow is absent; when Langflow is installed, the broken import runs during collection.

---

Suggested fix (pick one)

A. Restore component — Add praisonai/flow/components/PraisonAI/praisonai_task.py implementing PraisonAITaskComponent (if product intent).

B. Remove/update test — Drop task component tests or rewrite to use only shipped components until task component lands.

C. Defensive import — Lazy-import inside tests or:

pytest.importorskip("langflow")
praisonai_task = pytest.importorskip("praisonai.flow.components.PraisonAI.praisonai_task")

D. CI matrix — Run wrapper unit tests with and without [langflow] extra; fail if collection errors.

---

Acceptance criteria

• pytest src/praisonai/tests/unit completes collection with Langflow installed (no exit 2)
• test_langflow_components.py either passes or is skipped with clear reason
• Document Langflow optional path in contributor docs

---

Workaround (local audit)

pytest src/praisonai/tests/unit --ignore=src/praisonai/tests/unit/test_langflow_components.py

Or uninstall Langflow so importorskip("langflow") skips the module (hides the product gap).

---

Duplicate search

gh search issues --repo MervinPraison/PraisonAI "praisonai_task langflow" → no matches (2026-09-29).

[praisonai-triage-agent]

👋 Thanks for opening this issue, @Dhivya-Bharathy!

A maintainer will review this shortly. In the meantime:

• Make sure you've included steps to reproduce (for bugs)
• Check existing issues for duplicates
• Review the documentation for related guides

Bug and enhancement reports are auto-triaged with Claude. Questions and other issues: a maintainer can comment @claude to trigger analysis.

Routing: Agent-callable tools → PraisonAI-Tools; lifecycle plugins (tracing/hooks/guardrails) → PraisonAI-Plugins. TypeScript/JavaScript SDK fixes land in src/praisonai-ts/ in this repo.

[praisonai-triage-agent]

Claude finished @Dhivya-Bharathy's task —— View job • claude/issue-5361-20260929-0941 • [Create PR ➔](https://github.com/MervinPraison/PraisonAI/compare/main...claude/issue-5361-20260929-0941?quick_pull=1&title=Issue%20%235361%3A%20Changes%20from%20Claude&body=This%20PR%20addresses%20issue%20%235361%0A%0AGenerated%20with%20%5BClaude%20Code%5D(https%3A%2F%2Fclaude.ai%2Fcode)

---

Fixed broken Langflow test import ✅

• Read test file & component directory
• Apply minimal defensive fix
• Test collection (skips cleanly, no exit 2)
• Commit, push, open PR

Root cause

test_langflow_components.py imported the non-existent module praisonai.flow.components.PraisonAI.praisonai_task (PraisonAITaskComponent). importorskip("langflow") only skips when Langflow is absent; when it's installed, the broken import runs during collection → pytest src/praisonai/tests/unit aborts with exit 2.

Only praisonai_agent.py and praisonai_agents.py ship. Also, PraisonAIAgentsComponent.build_agents() no longer accepts a tasks param (tasks are auto-generated from agents) — so the task component/test was pure repo drift.

Fix (minimal — Option B)

• Removed the praisonai_task import and test_praisonai_task_component.
• Updated test_praisonai_agents_component to match the current API (no tasks param), referencing only shipped components.

No new modules or params added — surface area stays lightweight. Rejected Option A (adding a new praisonai_task component) as scope creep with no live consumer.

PR: #5365
• Branch