Fix PR 513 review follow-ups#526
Merged
Merged
Conversation
0296f31 to
2e97902
Compare
…ments # Conflicts: # crates/skippy-server/src/frontend/tests.rs # crates/skippy-server/src/openai.rs
ndizazzo
approved these changes
May 13, 2026
michaelneale
approved these changes
May 13, 2026
Collaborator
michaelneale
left a comment
There was a problem hiding this comment.
ok I think - one small thing:
falls back explicitly to filesystem sizing
do we want it to fall back or fail? are files a reasonable proxy?
Collaborator
Author
|
Good call. I dropped the fallback instead of keeping filesystem sizing. For this runtime-load path, guessing is worse than failing: layer-package refs need the package identity/manifest source bytes, and a zero or file-size estimate can make capacity planning lie. Direct GGUFs still get their normal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to PR #513 after it landed on
main. It keeps the original context-smart package work as merged and narrows this PR to the remaining review comments that were still actionable after the stale threads were closed.The main theme is making split orchestration more deterministic under bad or stale peer metadata: coordinator terms should not be invented from shutdown generations, rejected claims should be inspectable by the caller, malformed coordinator IDs should be visible in logs, and UI participation checks should not infer identity from string prefixes.
Review Comment Coverage
Coordinator and Claim State
coordinator_term: 0instead of reusingshutdown_generation. These are separate concepts: shutdown generation is a local lifecycle counter, while coordinator term belongs to the coordinator claim protocol.StagePreparationStatus.coordinator_idvalues are logged with the parse error before being dropped. The previous behavior made bad gossip indistinguishable from an intentionally missing coordinator ID.Split Planning
unwrap_or(Ok(0)).unwrap_or(0)path could silently turn planning failures into zero-byte estimates.Coordinator Topology Search
plan_topologyvisits each subset through a callback instead of materializing every combination into aVec<Vec<_>>first, which removes avoidable memory pressure on larger peer sets while preserving the existing ordering and selection behavior.UI Status Handling
node_idis optional in the API/UI types.OpenAI Admission Coverage
Retry-Afterheader.Compatibility
This does not introduce a protocol shape change. The coordinator ID parse handling remains tolerant of absent or invalid IDs, and the stop request term is set to the neutral value rather than introducing a new field or semantic requirement.
Validation
cargo fmt --all -- --checkcargo check -p mesh-llm-host-runtimecargo test -p skippy-coordinator --libLLAMA_STAGE_BUILD_DIR=.deps/llama-build/build-stage-abi-metal cargo test -p skippy-server --libjust buildcc @michaelneale