Open
Conversation
Collaborator
|
See stfc/PSyclone#3291 for discussion of a proper API to obtain built-in names. |
MatthewHambley
requested changes
Feb 27, 2026
Collaborator
MatthewHambley
left a comment
MatthewHambley
left a comment
There was a problem hiding this comment.
Just one question.
Comment on lines
+13
to
+16
| try: | ||
| from psyclone.domain.lfric.lfric_builtins import BUILTIN_MAP # type: ignore | ||
| except ImportError: | ||
| BUILTIN_MAP = {} |
Collaborator
There was a problem hiding this comment.
Checking the PSyclone source, the BUILTIN_MAP variable was added 9 years ago so is there a need to handle its non-existance?
Collaborator
Author
There was a problem hiding this comment.
Yes, it is required in case that you don't have PSyclone installed.
Collaborator
Author
There was a problem hiding this comment.
I've added a comment to explain this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny fix to remove unnecessary message in log files. Fixes #539.