Open
Conversation
Collaborator
Author
|
I've added a new test file for find_source_file (which covers all line of that file). I've also fixed some outdated names of ArtefactSets n the documentation (while looking for where to document the changed include/exclude functionality ... turns out it's only coming from the docstring :) ). |
hiker
requested review from
a team and
mo-lucy-gordon
and removed request for
a team
Collaborator
Author
|
Ready for review. @yaswant .... Oh, I could select the fab-code reviewer myself now!!!! Hoooooray |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #471 by picking the longest filter to decide if a file is included or excluded (and last one in case of same length filter).
This seems to match the behaviour of FCM, and allows e.g. the um to be compiled with Fab without change in the um-atmos-common.cfg file.