Revise and optimise PMSL calculation#348
Open
iboutle wants to merge 15 commits intoMetOffice:mainfrom
Open
Conversation
Merge remote-tracking branch 'jbruten/vn3.0_local_build_fixes' into vn3.0_pmsl
29 tasks
james-bruten-mo
approved these changes
Mar 9, 2026
tommbendall
approved these changes
Mar 12, 2026
Contributor
tommbendall
left a comment
There was a problem hiding this comment.
Science Review
There's a small typo in a comment but otherwise this looks good, so I would be happy for this to proceed to code review
interfaces/physics_schemes_interface/source/algorithm/pmsl_alg_mod.x90
Outdated
Show resolved
Hide resolved
…_mod.x90 Co-authored-by: Thomas Bendall <14180399+tommbendall@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: @tommbendall
Code Reviewer: @MatthewHambley
The calculation of pressure at mean sea-level (PMSL) is currently exceedingly expensive in the operational global model setup. This PR makes 2 changes to dramatically reduce its cost:
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - vn3.1_pmsl/run4
Suite Information
Task Information
✅ succeeded tasks - 1164
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review