merge: bring big int state protection into edit mode branch#125
Open
seankmartin wants to merge 4 commits intofeature/edit-modefrom
Open
merge: bring big int state protection into edit mode branch#125seankmartin wants to merge 4 commits intofeature/edit-modefrom
seankmartin wants to merge 4 commits intofeature/edit-modefrom
Conversation
…e#913) Fixes google#905 Prior to google#876, any transform specified for an OME-zarr multiscale dataset (and/or its base scale level) was handled internally and not exposed to users. After google#876, the transform was exposed as the default coordinate transform instead of being applied internally in all cases, which changed the meaning of existing states with an explicitly-specified transform if the extracted transform is not the identity transform. This commit changes the behavior back to the pre-google#876 behavior for OME metadata versions less than 0.6. For OME metadata versions >= 0.6, the post-google#876 behavior remains.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should also fix the big int that is ending up in the state, but this will help protect against it