#VFB-237 - Update CI/CD Pipeline to V3.0.0#221
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ac168efab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Updates the Virtual Fly Brain CI/CD configuration to use the CloudHarness v3.0.0 base image naming (cloudharness-base), aligning dev builds/deployments with the new base image and ensuring the application Docker image has curl available for build steps.
Changes:
- Switched Codefresh dev pipeline build references from
cloudharness-base-debiantocloudharness-base. - Updated Helm values build dependencies to reference
cloudharness-base. - Added
curlto the application Dockerfile package install list.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| deployment/codefresh-dev.yaml | Updates base-image build references to cloudharness-base and adjusts build args accordingly. |
| applications/virtual-fly-brain/Dockerfile | Installs curl during image build. |
| applications/virtual-fly-brain/deploy/values.yaml | Updates build dependency name to cloudharness-base. |
| applications/virtual-fly-brain/deploy/values-dev.yaml | Updates build dependency name to cloudharness-base. |
Comments suppressed due to low confidence (1)
deployment/codefresh-dev.yaml:138
- The dev pipeline no longer publishes the base image to the publish registry:
publishonly pushescloudharness-flaskandvirtual-fly-brain. Since the base image name was changed tocloudharness-base, this stage should also push${{REGISTRY}}/virtual-fly-brain/cloudharness-base:${{CF_BUILD_ID}}(similar todeployment/codefresh-prod.yaml:70-78) or the base image will be missing from${{REGISTRY_PUBLISH_URL}}for the${{DEPLOYMENT_PUBLISH_TAG}}.
publish:
type: parallel
stage: publish
steps:
publish_cloudharness-flask:
stage: publish
type: push
title: Cloudharness flask
candidate: '${{REGISTRY}}/virtual-fly-brain/cloudharness-flask:${{CF_BUILD_ID}}'
tags:
- '${{DEPLOYMENT_PUBLISH_TAG}}'
registry: '${{REGISTRY_PUBLISH_URL}}'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7b21b19 to
70452d4
Compare
Update CI/CD Pipeline to V3.0.0
Migration to new base image:
cloudharness-base-debiantocloudharness-basein the build and deployment pipeline, including image names, dockerfiles, and build arguments indeployment/codefresh-dev.yaml. [1] [2] [3]values.yamlandvalues-dev.yamlto usecloudharness-baseinstead ofcloudharness-base-debian.Dockerfile improvements:
curlto the list of installed packages in the application Dockerfile (applications/virtual-fly-brain/Dockerfile).