fix: menu item hover

[n3ps]

Description

Fix the menu item icon color on hover

Changelog

CHANGELOG entry: fix: menu icon hover color

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

---

Note

Ensures .menu-item text/icon color remains unchanged on hover/active by adding color: inherit while keeping the hover background.

• UI Styles (ui/components/ui/menu/menu.scss)
  • .menu-item: On :hover/:active, explicitly sets color: inherit to prevent color shift; retains hover background styling.

^{Written by Cursor Bugbot for commit 36b843e. This will update automatically on new commits. Configure here.}

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [36b843e]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• bundle size: Bundle Size Stats
• user-actions-benchmark: User Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16
  • content-script: 0
  • offscreen: 0

UI Startup Metrics (1203 ± 90 ms)

Platform	BuildType	Page	Metric	Mean (ms)	Min (ms)	Max (ms)	Std Dev (ms)	P 75 (ms)	P 95 (ms)
Chrome	Browserify	Standard Home	uiStartup	1203	1060	1464	90	1262	1396
			load	1043	916	1280	82	1089	1190
			domContentLoaded	1037	905	1274	81	1083	1180
			domInteractive	22	14	95	18	18	74
			firstPaint	629	100	1241	408	1052	1156
			backgroundConnect	231	215	275	9	234	250
			firstReactRender	27	19	53	6	28	40
			getState	21	8	64	9	24	40
			initialActions	1	0	5	1	1	2
			loadScripts	812	668	1047	81	867	948
			setupStore	10	7	29	3	11	18
			numNetworkReqs	13	6	76	20	6	73
	Browserify	Power User Home	uiStartup	2121	1917	2584	186	2195	2584
			load	1128	967	1539	197	1406	1539
			domContentLoaded	1108	956	1526	202	1396	1526
			domInteractive	51	18	153	50	108	153
			firstPaint	523	126	1072	340	992	1072
			backgroundConnect	248	239	264	8	251	264
			firstReactRender	72	46	95	15	86	95
			getState	226	170	298	36	246	298
			initialActions	1	0	2	1	1	2
			loadScripts	882	726	1298	199	1162	1298
			setupStore	31	16	49	10	42	49
			numNetworkReqs	122	89	190	33	155	190
	Webpack	Standard Home	uiStartup	868	727	1298	112	869	1225
			load	630	568	1042	98	628	963
			domContentLoaded	622	563	1018	94	623	944
			domInteractive	19	12	75	15	15	64
			firstPaint	212	62	1021	240	156	948
			backgroundConnect	26	12	93	14	26	60
			firstReactRender	32	20	74	9	38	41
			getState	12	6	33	4	13	17
			initialActions	1	0	6	1	1	2
			loadScripts	619	561	1007	91	621	931
			setupStore	13	6	38	6	14	24
			numNetworkReqs	13	6	73	19	8	68
	Webpack	Power User Home	uiStartup	1078	910	1695	230	1282	1695
			load	666	574	927	125	787	927
			domContentLoaded	653	564	906	118	772	906
			domInteractive	29	13	94	29	42	94
			firstPaint	334	63	910	292	599	910
			backgroundConnect	50	11	265	62	51	265
			firstReactRender	41	38	45	2	42	45
			getState	141	94	166	21	153	166
			initialActions	1	0	2	0	1	2
			loadScripts	648	562	896	114	761	896
			setupStore	10	6	26	6	13	26
			numNetworkReqs	75	62	122	18	84	122
Firefox	Browserify	Standard Home	uiStartup	1468	1319	1995	124	1501	1767
			load	1234	1132	1634	88	1262	1431
			domContentLoaded	1233	1131	1633	88	1261	1431
			domInteractive	53	28	211	37	51	159
			firstPaint	-	-	-	-	-	-
			backgroundConnect	42	23	132	17	48	80
			firstReactRender	28	22	62	7	27	42
			getState	12	7	62	7	11	23
			initialActions	1	0	3	1	2	2
			loadScripts	1209	1115	1590	83	1233	1407
			setupStore	13	7	64	10	13	34
			numNetworkReqs	12	6	61	15	7	56
	Browserify	Power User Home	uiStartup	3102	2561	4362	469	3386	4362
			load	1492	1273	1945	209	1706	1945
			domContentLoaded	1492	1273	1944	209	1705	1944
			domInteractive	254	80	734	203	487	734
			firstPaint	-	-	-	-	-	-
			backgroundConnect	499	131	1287	359	772	1287
			firstReactRender	87	61	120	16	97	120
			getState	176	92	536	98	179	536
			initialActions	2	1	3	1	3	3
			loadScripts	1443	1239	1921	204	1670	1921
			setupStore	85	33	180	48	128	180
			numNetworkReqs	122	76	223	55	202	223
	Webpack	Standard Home	uiStartup	1709	1464	2153	146	1746	2069
			load	1450	1271	1770	113	1512	1727
			domContentLoaded	1450	1271	1770	113	1511	1726
			domInteractive	56	30	123	24	66	114
			firstPaint	-	-	-	-	-	-
			backgroundConnect	58	26	224	36	58	160
			firstReactRender	37	26	112	16	37	86
			getState	15	7	162	18	13	52
			initialActions	2	0	3	1	2	3
			loadScripts	1412	1253	1716	105	1464	1644
			setupStore	18	7	202	23	13	62
			numNetworkReqs	13	6	67	17	7	63
	Webpack	Power User Home	uiStartup	3236	2598	4641	577	3633	4641
			load	1675	1384	2134	247	1924	2134
			domContentLoaded	1675	1384	2133	247	1924	2133
			domInteractive	255	80	700	198	438	700
			firstPaint	-	-	-	-	-	-
			backgroundConnect	379	139	1044	252	557	1044
			firstReactRender	91	56	131	22	104	131
			getState	208	105	697	139	226	697
			initialActions	2	1	3	1	3	3
			loadScripts	1638	1358	2078	242	1886	2078
			setupStore	114	29	296	76	170	296
			numNetworkReqs	126	76	231	54	172	231

📊 Page Load Benchmark Results

Current Commit: 36b843e | Date: 11/15/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

• pageLoadTime-> current mean value: 1.04s (±43ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
• domContentLoaded-> current mean value: 725ms (±42ms) 🟢 | historical mean value: 718ms ⬆️ (historical data)
• firstContentfulPaint-> current mean value: 78ms (±13ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric	Mean	Std Dev	Min	Max	P95	P99
pageLoadTime	1.04s	43ms	1.02s	1.39s	1.07s	1.39s
domContentLoaded	725ms	42ms	708ms	1.07s	749ms	1.07s
firstPaint	78ms	13ms	60ms	192ms	88ms	192ms
firstContentfulPaint	78ms	13ms	60ms	192ms	88ms	192ms
largestContentfulPaint	0ms	0ms	0ms	0ms	0ms	0ms

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 58 Bytes (0%)
• ui: 11.34 KiB (0.15%)
• common: 207 Bytes (0%)