Skip to content

Conversation

@sophieqgu
Copy link
Contributor

@sophieqgu sophieqgu commented Nov 18, 2025

Description

Duplicate of #37818 rebased onto main
Small ui fixes to button color and prevent overflow

Open in GitHub Codespaces

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Refines Rewards Onboarding modal layout and imagery to prevent overflow, adjusts modal height, and adds button hover styling.

  • Rewards Onboarding UI:
    • Layout/Sizing:
      • Reduce OnboardingModal height from 800px to 740px.
      • Tweak intro image positioning to top: '25%' and remove extra margins.
      • Add top: 0 to step SVGs; set step images to width: '94%' and drop w-full to prevent overflow.
      • Adjust info containers (remove min-h-30, center content in Step 4) for better vertical alignment.
    • Buttons:
      • Add hover:bg-default-hover for the primary confirm button on the intro step.
      • Ensure skip button retains hover styling.

Written by Cursor Bugbot for commit 2bc0e5f. This will update automatically on new commits. Configure here.

@metamaskbot metamaskbot added the team-rewards Rewards team label Nov 18, 2025
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sophieqgu sophieqgu changed the title UI fixes button color and overflow fix: rewards UI fixes button color and overflow Nov 18, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [2bc0e5f]
UI Startup Metrics (1263 ± 96 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup1263110816079613161429
load108793913648411461222
domContentLoaded107993413528511421212
domInteractive2414100191980
firstPaint62993125042710721211
backgroundConnect23722334915238261
firstReactRender31195793749
getState26892142958
initialActions108113
loadScripts850712110383916983
setupStore1273951420
numNetworkReqs1367619670
BrowserifyPower User HomeuiStartup22532007270121423862701
load11751016154919414581549
domContentLoaded1152999151419214371514
domInteractive572018450120184
firstPaint657220153851111401538
backgroundConnect25824031016268310
firstReactRender81521191994119
getState21417927331232273
initialActions207227
loadScripts917774127118711851271
setupStore321554103854
numNetworkReqs1249518831164188
WebpackStandard HomeuiStartup8627391207968731103
load62457395379625859
domContentLoaded61756893375617840
domInteractive181269131457
firstPaint18863936189200624
backgroundConnect261286153063
firstReactRender332073113757
getState1163241318
initialActions102111
loadScripts61456692373613829
setupStore1254051318
numNetworkReqs1367319870
WebpackPower User HomeuiStartup12631087188720413911887
load74661211731508791173
domContentLoaded71959711191387921119
domInteractive461617749106177
firstPaint43013111253326711125
backgroundConnect66141804887180
firstReactRender50455425254
getState1679919833192198
initialActions112012
loadScripts71559511101357831110
setupStore1383581535
numNetworkReqs78641311981131
FirefoxBrowserifyStandard HomeuiStartup14761311206712814991779
load1239113015468612521451
domContentLoaded1238113015458612521451
domInteractive55331973952165
firstPaint------
backgroundConnect3924112144557
firstReactRender29228992843
getState1173951123
initialActions203122
loadScripts1216111414728212321426
setupStore157159171336
numNetworkReqs1266315759
BrowserifyPower User HomeuiStartup34452672488973239074889
load15711332221227819342212
domContentLoaded15711332221127819332211
domInteractive25092669193496669
firstPaint------
backgroundConnect624102154446910461544
firstReactRender874712826106128
getState20676552116292552
initialActions213133
loadScripts15331305215427218482154
setupStore13041487128179487
numNetworkReqs1247125260137252
WebpackStandard HomeuiStartup16281423196912416661926
load13801217164910114331583
domContentLoaded13791217164910114331583
domInteractive58292032770113
firstPaint------
backgroundConnect50232092854109
firstReactRender352583143480
getState1175161220
initialActions102122
loadScripts1347120216169614001543
setupStore13672111337
numNetworkReqs1366917866
WebpackPower User HomeuiStartup31952590423355739804233
load16841448228425519752284
domContentLoaded16841448228325519752283
domInteractive26372688215517688
firstPaint------
backgroundConnect392192815241672815
firstReactRender88491392095139
getState176110601112162601
initialActions213023
loadScripts16341422221524119242215
setupStore954816536119165
numNetworkReqs1287224763202247
📊 Page Load Benchmark Results

Current Commit: 2bc0e5f | Date: 11/18/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.04s (±46ms) 🟡 | historical mean value: 1.04s ⬇️ (historical data)
  • domContentLoaded-> current mean value: 726ms (±42ms) 🟢 | historical mean value: 729ms ⬇️ (historical data)
  • firstContentfulPaint-> current mean value: 78ms (±15ms) 🟢 | historical mean value: 78ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.04s 46ms 1.02s 1.42s 1.07s 1.42s
domContentLoaded 726ms 42ms 701ms 1.07s 749ms 1.07s
firstPaint 78ms 15ms 60ms 212ms 88ms 212ms
firstContentfulPaint 78ms 15ms 60ms 212ms 88ms 212ms
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 53 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 20 Bytes (0%)

@VGR-GIT VGR-GIT enabled auto-merge November 19, 2025 07:57
@VGR-GIT VGR-GIT added this pull request to the merge queue Nov 19, 2025
Merged via the queue into main with commit 1439428 Nov 19, 2025
184 of 188 checks passed
@VGR-GIT VGR-GIT deleted the onboarding-ui-fixes-2 branch November 19, 2025 08:55
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2025
@metamaskbot metamaskbot added the release-13.11.0 Issue or pull request that will be included in release 13.11.0 label Nov 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-13.11.0 Issue or pull request that will be included in release 13.11.0 size-S team-rewards Rewards team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants