fix: remove browser navigation on account click when in initial connection flow #22604
+70
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
.../MultichainAccounts/MultichainAccountsConnectedList/MultichainAccountsConnectedList.test.tsx
Show resolved
Hide resolved
jiexi
reviewed
Nov 13, 2025
Comment on lines
72
to
75
| if (isConnectionFlow) { | ||
| AccountTreeController.setSelectedAccountGroup(accountGroup.id); | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
should this guard get moved to below line 77?
adonesky1
reviewed
Nov 13, 2025
Comment on lines
71
to
77
| // During connection flow, clicking an account should only change the selected account group instead of navigating | ||
| if (isConnectionFlow) { | ||
| AccountTreeController.setSelectedAccountGroup(accountGroup.id); | ||
| return; | ||
| } | ||
|
|
||
| AccountTreeController.setSelectedAccountGroup(accountGroup.id); |
Contributor
There was a problem hiding this comment.
right?
Suggested change
| // During connection flow, clicking an account should only change the selected account group instead of navigating | |
| if (isConnectionFlow) { | |
| AccountTreeController.setSelectedAccountGroup(accountGroup.id); | |
| return; | |
| } | |
| AccountTreeController.setSelectedAccountGroup(accountGroup.id); | |
| // During connection flow, clicking an account should only change the selected account group instead of navigating | |
| AccountTreeController.setSelectedAccountGroup(accountGroup.id); | |
| if (isConnectionFlow) { | |
| return; | |
| } |
Contributor
There was a problem hiding this comment.
I agree, the early return can be done after setSelectedAccountGroup
montelaidev
approved these changes
Nov 14, 2025
Contributor
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsFallback: AI analysis did not complete successfully. Running all tests. |
|
metamaskbot
added
the
release-7.61.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes browser navigation when a user clicks the account group in the initial connection flow.
Changelog
CHANGELOG entry: Fixes navigation on account group click in initial connection flow
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/WAPI-829
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2025-11-13.at.09.55.37.mov
After
Screen.Recording.2025-11-13.at.09.49.44.mov
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Selecting an account during the initial connection flow now only updates the selected account group without showing a toast or navigating; wiring and tests updated accordingly.
MultichainAccountsConnectedList.tsx)isConnectionFlowprop (defaultfalse).handleSelectAccountto early-return in connection flow (only setsAccountTreeController.setSelectedAccountGroup).navigation.navigate(Routes.BROWSER.HOME)when not in connection flow; update hook deps.MultichainPermissionsSummary.tsx)isConnectionFlow={!isAlreadyConnected}toMultichainAccountsConnectedListand update memo deps.MultichainAccountsConnectedList.test.tsx)isConnectionFlowin relevant tests and validate correct group IDs and side effects.Written by Cursor Bugbot for commit 952b327. This will update automatically on new commits. Configure here.