-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
refactor: update multichain address sorting logic and tests #22623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: update multichain address sorting logic and tests #22623
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
8b535db to
a487cac
Compare
396339c to
dae32b6
Compare
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsAfter analyzing the changed files, I found that all 6 files are related to multichain account management and address selection functionality. Here's the breakdown: Files Changed:
Key Functionality Impacted:
Why These Tags:
Risk Assessment - Medium:
Confidence: 75%
|
|



Description
The current ordering of chains in the Receiving Address and Account Selector screens feels arbitrary, mixing EVM and non-EVM networks without logical prioritization.
For users managing multiple chains, especially newcomers, this inconsistency causes cognitive load and confusion when trying to locate primary networks like Ethereum, Bitcoin, or Solana.
This PR changes the order of networks to: first set of networks being [Ethereum, Bitcoin, Solana, Tron, Linea] and then the rest.
Changelog
CHANGELOG entry: Updates the order of networks on networks list
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/TMCU-175
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Reorders multichain address sorting to ETH > BTC > SOL > TRX > Linea, normalizes CAIP IDs, and updates selectors, tests, and snapshots to match.
MultichainAddressRowsList.utils.ts):Ethereum (0),Bitcoin (1),Solana (2),Tron (3),Linea (4), then featured, others, testnets last.extractHexChainId.BtcScopeandTrxScopehandling; update sorting docstring.app/selectors/multichainAccounts/accounts.ts):sortNetworkAddressItemsto order account-scope items consistently across views.Written by Cursor Bugbot for commit dae32b6. This will update automatically on new commits. Configure here.