Skip to content

chore: enable predict for non-evm networks #22657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 13, 2025
+10 −10
Merged

chore: enable predict for non-evm networks #22657

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b3d86ef
chore: enable predict for non-evm networks
caieu Nov 12, 2025
6b3c299
fix: test
caieu Nov 13, 2025
160aa26
fix: cursor comment
caieu Nov 13, 2025
88abdc7
fix: cursor comment
caieu Nov 13, 2025
bcbbe91
Merge branch 'main' into chore/predict-enable-non-evm
caieu Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/components/Nav/Main/MainNavigator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,8 +942,8 @@ const MainNavigator = () => {
// Get feature flag state for conditional Predict screen registration
const predictEnabledFlag = useSelector(selectPredictEnabledFlag);
const isPredictEnabled = useMemo(
() => predictEnabledFlag && isEvmSelected,
[predictEnabledFlag, isEvmSelected],
() => predictEnabledFlag,
[predictEnabledFlag],
);
const { enabled: isSendRedesignEnabled } = useSelector(
selectSendRedesignFlags,
Expand Down
4 changes: 2 additions & 2 deletions app/components/Views/ActivityView/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,8 @@ const ActivityView = () => {
const [activeTabIndex, setActiveTabIndex] = useState(0);
const predictEnabledFlag = useSelector(selectPredictEnabledFlag);
const isPredictEnabled = useMemo(
() => predictEnabledFlag && isEvmSelected,
[predictEnabledFlag, isEvmSelected],
() => predictEnabledFlag,
[predictEnabledFlag],
);

const openAccountSelector = useCallback(() => {
Expand Down
8 changes: 4 additions & 4 deletions app/components/Views/TradeWalletActions/TradeWalletActions.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,7 +627,7 @@ describe('TradeWalletActions', () => {
expect(mockOnDismiss).not.toHaveBeenCalled();
});

it('should not show Predict button on non-EVM networks', () => {
it('should show Predict button on non-EVM networks', () => {
(
selectPredictEnabledFlag as jest.MockedFunction<
typeof selectPredictEnabledFlag
Expand All @@ -643,7 +643,7 @@ describe('TradeWalletActions', () => {
...mockInitialState,
};

const { queryByTestId } = renderScreen(
const { getByTestId } = renderScreen(
TradeWalletActions,
{
name: 'TradeWalletActions',
Expand All @@ -654,7 +654,7 @@ describe('TradeWalletActions', () => {
);

expect(
queryByTestId(WalletActionsBottomSheetSelectorsIDs.PREDICT_BUTTON),
).toBeNull();
getByTestId(WalletActionsBottomSheetSelectorsIDs.PREDICT_BUTTON),
).toBeOnTheScreen();
});
});
2 changes: 1 addition & 1 deletion app/components/Views/TradeWalletActions/TradeWalletActions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ function TradeWalletActions() {
isDisabled={!canSignTransactions}
/>
)}
{isPredictEnabled && isEvmSelected && (
{isPredictEnabled && (
<ActionListItem
label={strings('asset_overview.predict_button')}
description={strings('asset_overview.predict_description')}
Expand Down
Loading