Fix palette config labels not updating when language changes - #1760
Closed
williamchange wants to merge 1 commit into
Closed
Fix palette config labels not updating when language changes#1760williamchange wants to merge 1 commit into
williamchange wants to merge 1 commit into
Conversation
MewPurPur
reviewed
Jul 31, 2026
| Configs.language_changed.connect(sync_localization) | ||
|
|
||
| func sync_localization() -> void: | ||
| set_label_text("") |
Owner
There was a problem hiding this comment.
This is not right, it clears the palette title. To be fair, if a palette's name is empty, it also needs to update to the locale's version of "Unnamed", so that part needs to be synced too, but this isn't right.
Contributor
Author
There was a problem hiding this comment.
ok I will close this since I do not understand this part enough
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for these labels not updating when language changes