Update quick-protection-app-initialization-cpp.md#1529
Open
lvkv wants to merge 1 commit intoMicrosoftDocs:mainfrom
Open
Update quick-protection-app-initialization-cpp.md#1529lvkv wants to merge 1 commit intoMicrosoftDocs:mainfrom
lvkv wants to merge 1 commit intoMicrosoftDocs:mainfrom
Conversation
Contributor
Contributor
Author
|
@ShannonLeavitt currently waiting on employer approval for the CLA. Shouldn't be too long! |
Contributor
Author
|
@microsoft-github-policy-service agree company="D. E. Shaw & Co., L.P." |
Contributor
|
@lvkv : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Contributor
Author
|
@ShannonLeavitt good to go! |
Contributor
|
IMPORTANT: When the changes are ready for publication, add a #label:"aq-pr-triaged" |
Contributor
Author
|
Any updates on this? |
Contributor
|
Can you review this old PR? @MicrosoftDocs/public-repo-pr-review-team |
Contributor
Author
|
Hi, just checking in! I’d like to point teammates at these docs for onboarding, but it’s hard to do that when these intro examples don’t compile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi team Azure! Just like #1426 and #1412, I've made a number of changes to the MIP SDK's C++ Quickstarts.
Note that these changes are necessary to compile and run your quickstart. As it currently currently written, your code does not compile because of typos, mismatched variable names, and other errors. These changes fix it all:
mAppInfotoappInfomipContext.Shutdown()tomipContext->ShutDown()(note the->and capitalD)I've also made a number of sorely-needed improvements to the readability of this document:
ReleaseAllResources(), which appears to be a C# method that was accidentally copy-pasted herestd::fooandmip::foonamespace qualification whenusing foo;was already specified. For example, the current documentation specifiesusing std::make_shared;, then proceeds to call it with a qualifyingstd::anyways... this appears to be because of copy-pastingusingdirectives; this has the added benefit of putting the more importantusing mip::directives above the less importantstdonesautotype specifiers instead of the current, seemingly random mixture ofautoand non-auto'\n'newline instead of the confusing"'\n"seen hereFinally, I've compiled and tested these changes on Windows and Linux, and feel free to ask questions and/or request changes. Thanks again for the work you've put into MPIP/AIP/RMS!