-
Notifications
You must be signed in to change notification settings - Fork 299
--image-version is incorrect parameter #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The command az sig image-version create uses the --image-version parameter with a managed image’s resource ID, which is incorrect. The --image-version flag is meant for specifying an existing image version (in a gallery) as the source, whereas a managed image source requires the --managed-image parameter. Also, the az sig image-version create will fail if there is not already an image definition present. You may want to add a step to make sure and create the image definition using az sig image-definition create
|
@mbiver : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 3612e0f: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
|
This pull request has been inactive for at least 14 days. If you are finished with your changes, don't forget to sign off. See the contributor guide for instructions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bug in the Azure CLI command example for migrating managed images to Azure Compute Gallery. The command was using an incorrect parameter (--image-version) that is meant for specifying an existing gallery image version as a source, when it should have been using --managed-image for a managed image resource ID source.
Key Changes:
- Corrected the
az sig image-version createcommand parameter from--image-versionto--managed-imagefor managed image migration
The command az sig image-version create uses the --image-version parameter with a managed image’s resource ID, which is incorrect. The --image-version flag is meant for specifying an existing image version (in a gallery) as the source, whereas a managed image source requires the --managed-image parameter.
Also, the az sig image-version create will fail if there is not already an image definition present. You may want to add a step to make sure and create the image definition using az sig image-definition create