-
Notifications
You must be signed in to change notification settings - Fork 21.8k
Highlight Trusted Signing endpoint region requirement #127868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…bidden troubleshooting Make the Endpoint region requirement obvious and provide a concrete example (403 Forbidden + SignerSign failure) with steps to resolve when the endpoint doesn’t match the region of the Trusted Signing account/certificate profile.
|
@michaelmsonne : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit 59ee6aa: ✅ Validation status: passed
For more details, please refer to the build report. |
|
Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
Removed the endpoint mismatch error example and its resolution steps from the document. The error comes from signtool not Trusted signing and signtool team prefers to keep it generic.
|
Updated RP after 1:1 chat with Meha. |
|
Learn Build status updates of commit aa6934f: ✅ Validation status: passed
For more details, please refer to the build report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances documentation clarity by emphasizing the critical requirement that the Trusted Signing endpoint URI must match the region of both the account and certificate profile. The change converts a standard paragraph into an IMPORTANT callout box to make this requirement more visible to users.
Key Changes
- Upgraded the endpoint region requirement from regular text to an IMPORTANT callout
- Added explicit mention that the endpoint must match both the account and certificate profile region
- Included troubleshooting context about 403 Forbidden errors caused by region/endpoint mismatches
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@TacoTechSharma We'll merge this PR based on your approval. If this article requires further changes, please open a separate pull request. Due to the upcoming conference, all merging and publishing is on hold until the morning of November 18th. This PR is ready for merge on November 18th. #label: "event-triaged-to-10AM" |
|
Are you trying to add/remove a custom label? The syntax for that is |
|
#label: "ready-to-merge" |
Make the Endpoint region requirement obvious as I see this can help to resolve when the endpoint doesn’t match the region of the Trusted Signing account/certificate profile. More clear for the eyes to see this requrement.