added basic round route and get/post round#152
Open
markfridman wants to merge 5 commits into
Open
Conversation
idancohen88
reviewed
Jan 21, 2019
| const express = require('express'); | ||
| const router = express.Router(); | ||
| const co = require('co'); | ||
| const consts = require('../utils/consts'); |
Collaborator
There was a problem hiding this comment.
consts not in used... remove it
idancohen88
reviewed
Jan 21, 2019
|
|
||
|
|
||
|
|
||
| // router.post('/events/change', co.wrap(function*(req, res) { |
idancohen88
reviewed
Jan 21, 2019
| // return res.status(403).json([{"error": "Action is not allowed - User doesn't have admin permissions"}]); | ||
| // } | ||
|
|
||
| // const round = new Round({ |
idancohen88
reviewed
Jan 21, 2019
| const eventId = req.params.eventId; | ||
| const roundId = uuid() | ||
| const round = new Round({ | ||
| _id: roundId, |
Collaborator
There was a problem hiding this comment.
We have _id built-in in mongo, why do we need it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.