defconfig: btrfs and usb drivers as a module#93
Merged
tiopex merged 5 commits intoMiyooCFW:masterfrom Jul 5, 2025
Merged
Conversation
tiopex
force-pushed
the
modules
branch
3 times, most recently
from
34d3537 to
f4d3471
Compare
there is tar-pkg with all modules
Apaczer
reviewed
Jun 26, 2025
drivers/input/keyboard/miyoo_kbd.c
Outdated
| if (miyoo_increase_volume) | ||
| symbol_put(MIYOO_INCREASE_VOLUME); | ||
| if (miyoo_decrease_volume) | ||
| symbol_put(MIYOO_DECREASE_VOLUME); |
Member
There was a problem hiding this comment.
since this is a keyboard module and to not mix stuff we could remove BACKLIGHT and VOLUME modification here and leave it for deamon (majority will probably use that in the end). What's your opinion?
add MIYOO_INCREASE/DECREASE_VOLUME() comments as ref.
Apaczer
approved these changes
Jul 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.