DRAFT: Fix for Issue/2089#2149
Draft
PatrickSteil wants to merge 2 commits intoMobilityData:masterfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR for #2089.
Problem
When any row in a file had a field-level validation error (e.g. an invalid URL in
agency.txt), CsvFileLoader sethasUnparsableRows = trueand returned anUNPARSABLE_ROWScontainer while discarding all entities from that file, including valid ones.This caused a silent cascade: if
agency.txthad even one bad field value, the agency table appeared empty to downstream validators, meaning invalidagency_idreferences inroutes.txtwent unreported.Root Cause
The
hasUnparsableRowsflag conflated two distinct problems:else ifbranch alreadyThe flag was only correct for the first case. For the second, the error is already recorded in
noticeContainer(line 126) and the entity is already excluded, settinghasUnparsableRows = truewas redundant and harmful.