Skip to content

solved issue 84 indeed#85

Open
FEPanalysis wants to merge 1 commit into
masterfrom
March23
Open

solved issue 84 indeed#85
FEPanalysis wants to merge 1 commit into
masterfrom
March23

Conversation

@FEPanalysis
Copy link
Copy Markdown
Contributor

Replaced 'skiprows' which got obsolete in numpy with 'skip_header'.
Also, the state will be read in as a float with subsequent conversion into an integer rather than being read in as an integer on the fly.

@davidlmobley
Copy link
Copy Markdown
Member

So, if we're going to do this we need to add a version requirement for numpy before the tool starts to run so that we can require people to have the updated numpy, otherwise we'll have people who run into the opposite error (their numpy will only recognize skiprows). The alternative solution is to do a version CHECK on numpy and then pick the appropriate functional call accordingly. But either way, slightly more is needed than what is here.

@FEPanalysis
Copy link
Copy Markdown
Contributor Author

Can someone test it with an earlier version?
My feeling is that numpy has been supporting both keywords for quite a while.

@FEPanalysis FEPanalysis reopened this Mar 25, 2016
@davidlmobley
Copy link
Copy Markdown
Member

I'll figure out how to get conda to pull an old numpy and test this with it
soon.

Thanks.

On Thu, Mar 24, 2016 at 5:21 PM, FEPanalysis notifications@github.com
wrote:

Reopened #85 #85.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#85 (comment)

David Mobley
dmobley@gmail.com
949-385-2436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants