Group Char*.cpp/h into src/source/Character/ (#344)#47
Conversation
Move the five Char-prefix files (CharacterManager, CharInfoBalloon, CharInfoBalloonMng, CharMakeWin, CharSelMainWin) and their headers into a Character/ subfolder. Second incremental subsystem grouping under issue sven-n#344. Updated 41 includes of CharacterManager.h, three includes in UIMng.h (CharSelMainWin/CharMakeWin/CharInfoBalloonMng), and one relative-path include in Scenes/CharacterScene.cpp to use the new Character/ prefix, matching the convention already used for Camera/, Scenes/, GameMaps/, etc. Out of scope (left flat for future passes - tracked in sven-n#344): - ZzzCharacter.cpp/h (15K LOC, 121 callers): core engine character file, belongs with a future Zzz* engine sweep. - w_CharacterInfo.cpp/h: defines _PATH_t pathfinding structs included by _struct.h - engine runtime state, not character UI. - NewUICharacterInfoWindow.cpp/h: NewUI* prefix, move with the NewUI/ group. Verified with a MinGW build of the Main target.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request continues the ongoing effort to organize the codebase by grouping related files into subdirectories. By moving character-specific components into a dedicated Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the project structure by moving character-related header files, including CharacterManager.h, CharSelMainWin.h, CharMakeWin.h, and CharInfoBalloonMng.h, into a dedicated Character subdirectory. All corresponding include directives across the codebase have been updated to reflect these new paths. I have no feedback to provide as there are no review comments.
Summary
Char-prefix files (CharacterManager,CharInfoBalloon,CharInfoBalloonMng,CharMakeWin,CharSelMainWin) and their headers intosrc/source/Character/CharacterManager.h, three includes inUIMng.h, and one relative-path include inScenes/CharacterScene.cppto use the newCharacter/prefixfile(GLOB_RECURSE source/*.cpp)auto-picks up subfolders)Second incremental subsystem grouping under sven-n#344, after
GameMaps/(PR #45).Out of scope - left flat for future passes
Tracked under sven-n#344 borderline-files table:
ZzzCharacter.cpp/h(15K LOC, 121 callers): core engine file, belongs with a futureZzz*engine sweepw_CharacterInfo.cpp/h: pathfinding structs included by_struct.h, engine runtime stateNewUICharacterInfoWindow.cpp/h:NewUI*prefix, move withNewUI/groupTest plan
Unix Makefiles+mingw-w64-i686.cmaketoolchain) ofMaintarget succeedssrc/CMakeFiles/Main.dir/source/Character/CharacterManager.cpp.objetc.)Main.exelinks successfully