Skip to content

Group Char*.cpp/h into src/source/Character/ (#344)#47

Merged
Mosch0512 merged 1 commit into
mainfrom
move-character
May 10, 2026
Merged

Group Char*.cpp/h into src/source/Character/ (#344)#47
Mosch0512 merged 1 commit into
mainfrom
move-character

Conversation

@Mosch0512
Copy link
Copy Markdown
Owner

Summary

  • Move the five Char-prefix files (CharacterManager, CharInfoBalloon, CharInfoBalloonMng, CharMakeWin, CharSelMainWin) and their headers into src/source/Character/
  • Update 41 callers that include CharacterManager.h, three includes in UIMng.h, and one relative-path include in Scenes/CharacterScene.cpp to use the new Character/ prefix
  • No CMake changes needed (file(GLOB_RECURSE source/*.cpp) auto-picks up subfolders)

Second incremental subsystem grouping under sven-n#344, after GameMaps/ (PR #45).

Out of scope - left flat for future passes

Tracked under sven-n#344 borderline-files table:

  • ZzzCharacter.cpp/h (15K LOC, 121 callers): core engine file, belongs with a future Zzz* engine sweep
  • w_CharacterInfo.cpp/h: pathfinding structs included by _struct.h, engine runtime state
  • NewUICharacterInfoWindow.cpp/h: NewUI* prefix, move with NewUI/ group

Test plan

  • MinGW build (Unix Makefiles + mingw-w64-i686.cmake toolchain) of Main target succeeds
  • Object files compile from new path (src/CMakeFiles/Main.dir/source/Character/CharacterManager.cpp.obj etc.)
  • Main.exe links successfully
  • MSVC build (not run locally)

Move the five Char-prefix files (CharacterManager, CharInfoBalloon,
CharInfoBalloonMng, CharMakeWin, CharSelMainWin) and their headers into
a Character/ subfolder. Second incremental subsystem grouping under
issue sven-n#344.

Updated 41 includes of CharacterManager.h, three includes in UIMng.h
(CharSelMainWin/CharMakeWin/CharInfoBalloonMng), and one relative-path
include in Scenes/CharacterScene.cpp to use the new Character/ prefix,
matching the convention already used for Camera/, Scenes/, GameMaps/, etc.

Out of scope (left flat for future passes - tracked in sven-n#344):
- ZzzCharacter.cpp/h (15K LOC, 121 callers): core engine character file,
  belongs with a future Zzz* engine sweep.
- w_CharacterInfo.cpp/h: defines _PATH_t pathfinding structs included by
  _struct.h - engine runtime state, not character UI.
- NewUICharacterInfoWindow.cpp/h: NewUI* prefix, move with the NewUI/
  group.

Verified with a MinGW build of the Main target.
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request continues the ongoing effort to organize the codebase by grouping related files into subdirectories. By moving character-specific components into a dedicated Character/ folder, the project improves modularity and maintainability. The changes are purely structural and do not require modifications to the CMake build configuration.

Highlights

  • File Organization: Moved five character-related files (CharacterManager, CharInfoBalloon, CharInfoBalloonMng, CharMakeWin, CharSelMainWin) into the src/source/Character/ directory.
  • Dependency Updates: Updated 41 source files to reflect the new include paths for the relocated character files.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the project structure by moving character-related header files, including CharacterManager.h, CharSelMainWin.h, CharMakeWin.h, and CharInfoBalloonMng.h, into a dedicated Character subdirectory. All corresponding include directives across the codebase have been updated to reflect these new paths. I have no feedback to provide as there are no review comments.

@Mosch0512 Mosch0512 merged commit 343724f into main May 10, 2026
3 checks passed
@Mosch0512 Mosch0512 deleted the move-character branch May 10, 2026 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant